feat: add private flag to some options to skip tracking for them

Author: KristianDD

lib/common/declarations.d.ts

@@ -1269,6 +1269,10 @@ interface IDashedOption {
 	 * Type of the option. It can be string, boolean, Array, etc.
 	 */
 	type: string;
+	/**
+	 * Should skip in tracking
+	 */
+	private?: boolean;
 	/**
 	 * Shorthand option passed on the command line with `-` sign, for example `-v`
 	 */

lib/helpers/options-track-helper.ts

@@ -3,7 +3,7 @@ import { TrackActionNames } from "../constants";
 
 export class OptionsTracker {
 	public static PASSWORD_DETECTION_STRING = "password";
-	public static PASSOWRD_REPLACE_VALUE = "private";
+	public static PRIVATE_REPLACE_VALUE = "private";
 	public static PATH_REPLACE_VALUE = "_localpath";
 	public static SIZE_EXEEDED_REPLACE_VALUE = "sizeExceeded";
 
@@ -34,13 +34,16 @@ export class OptionsTracker {
 			if (this.shouldSkipProperty(key, value, shorthands, optionsDefinitions)) {
 				delete data[key];
 			} else {
-				if (key.toLowerCase().indexOf(OptionsTracker.PASSWORD_DETECTION_STRING) >= 0) {
-					value = OptionsTracker.PASSOWRD_REPLACE_VALUE;
+				if (options && optionsDefinitions[key] && optionsDefinitions[key].private) {
+					value = OptionsTracker.PRIVATE_REPLACE_VALUE;
+				} else if (key.toLowerCase().indexOf(OptionsTracker.PASSWORD_DETECTION_STRING) >= 0) {
+					value = OptionsTracker.PRIVATE_REPLACE_VALUE;
 				} else if (_.isString(value) && value !== path.basename(value)) {
 					value = OptionsTracker.PATH_REPLACE_VALUE;
 				} else if (_.isObject(value) && !_.isArray(value)) {
 					value = this.sanitizeTrackObject(value);
 				}
+
 				data[key] = value;
 			}
 		});

lib/options.ts

@@ -12,9 +12,9 @@ export class Options {
 		verbose: { type: OptionType.Boolean, alias: "v" },
 		version: { type: OptionType.Boolean },
 		help: { type: OptionType.Boolean, alias: "h" },
-		profileDir: { type: OptionType.String },
+		profileDir: { type: OptionType.String, private: true },
 		analyticsClient: { type: OptionType.String },
-		path: { type: OptionType.String, alias: "p" },
+		path: { type: OptionType.String, alias: "p", private: true },
 		// This will parse all non-hyphenated values as strings.
 		_: { type: OptionType.String }
 	};
@@ -47,14 +47,14 @@ export class Options {
 			framework: { type: OptionType.String },
 			frameworkVersion: { type: OptionType.String },
 			forDevice: { type: OptionType.Boolean },
-			provision: { type: OptionType.Object },
+			provision: { type: OptionType.Object, private: true },
 			client: { type: OptionType.Boolean, default: true },
 			env: { type: OptionType.Object },
 			production: { type: OptionType.Boolean },
 			debugTransport: { type: OptionType.Boolean },
 			keyStorePath: { type: OptionType.String },
 			keyStorePassword: { type: OptionType.String, },
-			keyStoreAlias: { type: OptionType.String },
+			keyStoreAlias: { type: OptionType.String, private: true },
 			keyStoreAliasPassword: { type: OptionType.String },
 			ignoreScripts: { type: OptionType.Boolean },
 			disableNpmInstall: { type: OptionType.Boolean },
@@ -75,46 +75,48 @@ export class Options {
 			androidTypings: { type: OptionType.Boolean },
 			bundle: { type: OptionType.String },
 			all: { type: OptionType.Boolean },
-			teamId: { type: OptionType.Object },
+			teamId: { type: OptionType.Object, private: true },
 			syncAllFiles: { type: OptionType.Boolean, default: false },
 			chrome: { type: OptionType.Boolean },
 			inspector: { type: OptionType.Boolean },
 			clean: { type: OptionType.Boolean },
 			watch: { type: OptionType.Boolean, default: true },
 			background: { type: OptionType.String },
-			username: { type: OptionType.String },
+			username: { type: OptionType.String, private: true },
 			pluginName: { type: OptionType.String },
 			hmr: { type: OptionType.Boolean },
 			collection: { type: OptionType.String, alias: "c" },
 			json: { type: OptionType.Boolean },
-			avd: { type: OptionType.String },
+			avd: { type: OptionType.String, private: true },
+			// check not used
 			config: { type: OptionType.Array },
 			insecure: { type: OptionType.Boolean, alias: "k" },
 			debug: { type: OptionType.Boolean, alias: "d" },
 			timeout: { type: OptionType.String },
-			device: { type: OptionType.String },
-			availableDevices: { type: OptionType.Boolean },
-			appid: { type: OptionType.String },
-			geny: { type: OptionType.String },
+			device: { type: OptionType.String, private: true },
+			availableDevices: { type: OptionType.Boolean, private: true },
+			appid: { type: OptionType.String, private: true },
+			geny: { type: OptionType.String, private: true },
 			debugBrk: { type: OptionType.Boolean },
 			debugPort: { type: OptionType.Number },
 			start: { type: OptionType.Boolean },
 			stop: { type: OptionType.Boolean },
-			ddi: { type: OptionType.String }, // the path to developer  disk image
+			ddi: { type: OptionType.String, private: true }, // the path to developer  disk image
 			justlaunch: { type: OptionType.Boolean },
-			file: { type: OptionType.String },
+			file: { type: OptionType.String, private: true },
 			force: { type: OptionType.Boolean, alias: "f" },
+			// remove legacy
 			companion: { type: OptionType.Boolean },
 			emulator: { type: OptionType.Boolean },
 			sdk: { type: OptionType.String },
-			template: { type: OptionType.String },
-			certificate: { type: OptionType.String },
+			template: { type: OptionType.String, private: true },
+			certificate: { type: OptionType.String, private: true },
 			certificatePassword: { type: OptionType.String },
 			release: { type: OptionType.Boolean, alias: "r" },
-			var: { type: OptionType.Object },
+			var: { type: OptionType.Object, private: true },
 			default: { type: OptionType.Boolean },
 			count: { type: OptionType.Number },
-			analyticsLogFile: { type: OptionType.String },
+			analyticsLogFile: { type: OptionType.String, private: true },
 			hooks: { type: OptionType.Boolean, default: true },
 			link: { type: OptionType.Boolean, default: false },
 			aab: { type: OptionType.Boolean }