fix: codebuild destination warning (#5564)

* fix: xcodebuild destination warning

* test: update tests

Author: rigor789

lib/services/ios/xcodebuild-args-service.ts

@@ -38,17 +38,15 @@ export class XcodebuildArgsService implements IXcodebuildArgsService {
 		let productType: ProductArgs;
 		if (this.$iOSWatchAppService.hasWatchApp(platformData, projectData)) {
 			productType = ProductArgs.scheme;
-			args = args.concat([
-				"-destination",
-				"generic/platform=iOS Simulator",
-				"CODE_SIGNING_ALLOWED=NO",
-			]);
+			args = args.concat(["CODE_SIGNING_ALLOWED=NO"]);
 		} else {
 			args = args.concat(["CODE_SIGN_IDENTITY="]);
 		}
 
 		args = args
 			.concat([
+				"-destination",
+				"generic/platform=iOS Simulator",
 				"build",
 				"-configuration",
 				buildConfig.release ? Configurations.Release : Configurations.Debug,
@@ -83,6 +81,8 @@ export class XcodebuildArgsService implements IXcodebuildArgsService {
 			projectData.projectName + ".xcarchive"
 		);
 		const args = [
+			"-destination",
+			"generic/platform=iOS",
 			"archive",
 			"-archivePath",
 			archivePath,

test/services/ios/xcodebuild-args-service.ts

@@ -96,6 +96,8 @@ describe("xcodebuildArgsService", () => {
 						const expectedArgs = [
 							"ONLY_ACTIVE_ARCH=NO",
 							"CODE_SIGN_IDENTITY=",
+							"-destination",
+							"generic/platform=iOS Simulator",
 							"build",
 							"-configuration",
 							configuration,
@@ -170,6 +172,8 @@ describe("xcodebuildArgsService", () => {
 							);
 
 							const expectedArgs = [
+								"-destination",
+								"generic/platform=iOS",
 								"archive",
 								"-archivePath",
 								path.join(buildOutputPath, `${projectName}.xcarchive`),