Hot-fix of the xcrun to xcodebuild for TNS 2.5.x (#2684)

* Hot-fix of the xcrun to xcodebuild for TNS 2.5.x

* return the ipa path

Author: yyosifov

lib/services/ios-project-service.ts

@@ -423,22 +423,37 @@ export class IOSProjectService extends projectServiceBaseLib.PlatformProjectServ
 		}).future<void>()();
 	}
 
-	private createIpa(projectRoot: string): IFuture<void> {
+	/**
+	 * Exports .xcarchive for a development device.
+	 */
+	private exportDevelopmentArchive(projectData: IProjectData, options: { archivePath: string, exportDir?: string, teamID?: string }): IFuture<string> {
 		return (() => {
+			let projectRoot = this.platformData.projectRoot;
+			let archivePath = options.archivePath;
 			let buildOutputPath = path.join(projectRoot, "build", "device");
-			let xcrunArgs = [
-				"-sdk", "iphoneos",
-				"PackageApplication",
-				path.join(buildOutputPath, this.$projectData.projectName + ".app"),
-				"-o", path.join(buildOutputPath, this.$projectData.projectName + ".ipa")
+
+			// The xcodebuild exportPath expects directory and writes the <project-name>.ipa at that directory.
+			let exportPath = path.resolve(options.exportDir || buildOutputPath);
+			let exportFile = path.join(exportPath, projectData.projectName + ".ipa");
+
+			let args = ["-exportArchive",
+				"-archivePath", archivePath,
+				"-exportPath", exportPath,
+				"-exportOptionsPlist", this.platformData.configurationFilePath
 			];
-			// if (this.$logger.getLevel() !== "INFO") {
-				xcrunArgs.push("-verbose");
-			// }
-			// this.$logger.out("Packaging project...");
-			this.$childProcess.spawnFromEvent("xcrun", xcrunArgs, "exit", { cwd: this.$options, stdio: 'inherit' }).wait();
-			// this.$logger.out("Project package succeeded.");
-		}).future<void>()();
+
+			this.$childProcess.spawnFromEvent("xcodebuild", args, "exit", { stdio: 'inherit', cwd: this.$options }).wait();
+
+			return exportFile;
+		}).future<string>()();
+	}
+
+	private createIpa(projectRoot: string): IFuture<string> {
+		return (() => {
+			let xArchivePath = this.archive().wait();
+			let exportFileIpa = this.exportDevelopmentArchive(this.$projectData, { archivePath: xArchivePath }).wait();
+			return exportFileIpa;
+		}).future<string>()();
 	}
 
 	public isPlatformPrepared(projectRoot: string): boolean {