doctor doesn't crash on missing xcode tools (#3043)

* doctor doesn't crash on missing xcode tools
set a better message when components are up to date

* renamed method and fixed check

* added method return type

Author: Plamen5kov

lib/declarations.d.ts

@@ -604,10 +604,9 @@ interface IVersionsService {
 	getRuntimesVersions(): Promise<IVersionInformation[]>;
 
 	/**
-	 * Gets versions information about the nativescript components with new.
-	 * @return {Promise<IVersionInformation[]>} The version information.
+	 * Checks version information about the nativescript components and prints available updates if any.
 	 */
-	getComponentsForUpdate(): Promise<IVersionInformation[]>;
+	checkComponentsForUpdate(): Promise<void>;
 
 	/**
 	 * Gets versions information about all nativescript components.

lib/services/doctor-service.ts

@@ -95,7 +95,7 @@ class DoctorService implements IDoctorService {
 				result = true;
 			}
 
-			if (await this.$xcprojService.verifyXcproj(false)) {
+			if (sysInfo.xcodeVer && sysInfo.cocoapodVer && await this.$xcprojService.verifyXcproj(false)) {
 				result = true;
 			}
 		} else {
@@ -123,28 +123,15 @@ class DoctorService implements IDoctorService {
 			}
 		}
 
-		let versionsInformation: IVersionInformation[] = [];
 		try {
-			versionsInformation = await this.$versionsService.getComponentsForUpdate();
-			this.printVersionsInformation(versionsInformation);
+			await this.$versionsService.checkComponentsForUpdate();
 		} catch (err) {
 			this.$logger.error("Cannot get the latest versions information from npm. Please try again later.");
 		}
 
 		return doctorResult;
 	}
 
-	private printVersionsInformation(versionsInformation: IVersionInformation[]) {
-		if (versionsInformation && versionsInformation.length) {
-			let table: any = this.$versionsService.createTableWithVersionsInformation(versionsInformation);
-
-			this.$logger.warn("Updates available");
-			this.$logger.out(table.toString() + EOL);
-		} else {
-			this.$logger.out("Your components are up-to-date." + EOL);
-		}
-	}
-
 	private async promptForDocs(link: string): Promise<void> {
 		if (await this.$prompter.confirm("Do you want to visit the official documentation?", () => helpers.isInteractive())) {
 			this.$opener.open(link);

lib/services/versions-service.ts

@@ -1,3 +1,4 @@
+import { EOL } from "os";
 import * as constants from "../constants";
 import * as semver from "semver";
 import * as path from "path";
@@ -14,7 +15,8 @@ class VersionsService implements IVersionsService {
 		private $npmInstallationManager: INpmInstallationManager,
 		private $injector: IInjector,
 		private $staticConfig: Config.IStaticConfig,
-		private $pluginsService: IPluginsService) {
+		private $pluginsService: IPluginsService,
+		private $logger: ILogger) {
 		this.projectData = this.getProjectData();
 	}
 
@@ -84,7 +86,7 @@ class VersionsService implements IVersionsService {
 		return runtimesVersions;
 	}
 
-	public async getComponentsForUpdate(): Promise<IVersionInformation[]> {
+	public async checkComponentsForUpdate(): Promise<void> {
 		let allComponents: IVersionInformation[] = await this.getAllComponentsVersions();
 		let componentsForUpdate: IVersionInformation[] = [];
 
@@ -94,7 +96,18 @@ class VersionsService implements IVersionsService {
 			}
 		});
 
-		return componentsForUpdate;
+		this.printVersionsInformation(componentsForUpdate, allComponents);
+	}
+
+	private printVersionsInformation(versionsInformation: IVersionInformation[], allComponents: IVersionInformation[]): void {
+		if (versionsInformation && versionsInformation.length) {
+			let table: any = this.createTableWithVersionsInformation(versionsInformation);
+
+			this.$logger.warn("Updates available");
+			this.$logger.out(table.toString() + EOL);
+		} else {
+			this.$logger.out(`Your components are up-to-date: ${EOL}${allComponents.map(component => component.componentName)}${EOL}`);
+		}
 	}
 
 	public async getAllComponentsVersions(): Promise<IVersionInformation[]> {