Merge pull request #1633 from NativeScript/vladimirov/interpolate-all-android-files

Replace plugin variables in all Android .xml files

Author: rosen-vladimirov

lib/constants.ts

@@ -15,6 +15,7 @@ export var LIVESYNC_EXCLUDED_DIRECTORIES = ["app_resources"];
 export var TESTING_FRAMEWORKS = ['jasmine', 'mocha', 'qunit'];
 export let TEST_RUNNER_NAME = "nativescript-unit-test-runner";
 export let LIVESYNC_EXCLUDED_FILE_PATTERNS = ["**/*.js.map", "**/*.ts"];
+export let XML_FILE_EXTENSION = ".xml";
 
 export class ReleaseType {
 	static MAJOR = "major";

lib/services/android-project-service.ts

@@ -327,10 +327,11 @@ export class AndroidProjectService extends projectServiceBaseLib.PlatformProject
 				this.$fs.ensureDirectoryExists(resourcesDestinationDirectoryPath).wait();
 				shell.cp("-Rf", path.join(pluginPlatformsFolderPath, "*"), resourcesDestinationDirectoryPath);
 
-				let pluginConfigurationFilePath = path.join(resourcesDestinationDirectoryPath, this.platformData.configurationFileName);
-				if (this.$fs.exists(pluginConfigurationFilePath).wait()) {
-					this.$pluginVariablesService.interpolate(pluginData, pluginConfigurationFilePath).wait();
-				}
+				(this.$fs.enumerateFilesInDirectorySync(resourcesDestinationDirectoryPath, file => this.$fs.getFsStats(file).wait().isDirectory() || path.extname(file) === constants.XML_FILE_EXTENSION) || [])
+					.forEach(file => {
+						this.$logger.trace(`Interpolate data for plugin file: ${file}`);
+						this.$pluginVariablesService.interpolate(pluginData, file).wait();
+					});
 			}
 
 			// Copy include.gradle file

lib/xml-validator.ts

@@ -2,6 +2,7 @@
 "use strict";
 
 import { EOL } from "os";
+import * as constants from "./constants";
 
 export class XmlValidator implements IXmlValidator {
 	constructor(private $fs: IFileSystem,
@@ -11,7 +12,7 @@ export class XmlValidator implements IXmlValidator {
 		return (() => {
 			let xmlHasErrors = false;
 			sourceFiles
-				.filter(file => _.endsWith(file, ".xml"))
+				.filter(file => _.endsWith(file, constants.XML_FILE_EXTENSION))
 				.forEach(file => {
 					let errorOutput = this.getXmlFileErrors(file).wait();
 					let hasErrors = !!errorOutput;