fix: remove installPods property from platform's project interface

Author: Fatme

lib/definitions/project.d.ts

@@ -410,7 +410,7 @@ interface IPlatformProjectService extends NodeJS.EventEmitter, IPlatformProjectS
 	getAppResourcesDestinationDirectoryPath(projectData: IProjectData): string;
 
 	cleanDeviceTempFolder(deviceIdentifier: string, projectData: IProjectData): Promise<void>;
-	processConfigurationFilesFromAppResources(projectData: IProjectData, opts: { release: boolean,  installPods: boolean }): Promise<void>;
+	processConfigurationFilesFromAppResources(projectData: IProjectData, opts: { release: boolean }): Promise<void>;
 
 	/**
 	 * Ensures there is configuration file (AndroidManifest.xml, Info.plist) in app/App_Resources.

lib/services/ios-project-service.ts

@@ -791,7 +791,7 @@ We will now place an empty obsolete compatability white screen LauncScreen.xib f
 		this.$fs.deleteDirectory(this.getAppResourcesDestinationDirectoryPath(projectData));
 	}
 
-	public async processConfigurationFilesFromAppResources(projectData: IProjectData, opts: { release: boolean,  installPods: boolean }): Promise<void> {
+	public async processConfigurationFilesFromAppResources(projectData: IProjectData, opts: { release: boolean }): Promise<void> {
 		await this.mergeInfoPlists({ release: opts.release }, projectData);
 		await this.$iOSEntitlementsService.merge(projectData);
 		await this.mergeProjectXcconfigFiles(opts.release, projectData);
@@ -800,10 +800,6 @@ We will now place an empty obsolete compatability white screen LauncScreen.xib f
 		}
 
 		this.$pluginVariablesService.interpolateAppIdentifier(this.getPlatformData(projectData).configurationFilePath, projectData.projectIdentifiers.ios);
-
-		if (opts.installPods) {
-			await this.installPodsIfAny(projectData);
-		}
 	}
 
 	private getInfoPlistPath(projectData: IProjectData): string {

lib/services/prepare-platform-native-service.ts

@@ -42,9 +42,10 @@ export class PreparePlatformNativeService extends PreparePlatformService impleme
 			await config.platformData.platformProjectService.prepareProject(config.projectData, config.platformSpecificData);
 		}
 
-		const shouldPrepareModules = !config.changesInfo || config.changesInfo.modulesChanged;
+		const hasModulesChange = !config.changesInfo || config.changesInfo.modulesChanged;
+		const hasConfigChange = !config.changesInfo || config.changesInfo.configChanged;
 
-		if (shouldPrepareModules) {
+		if (hasModulesChange) {
 			await this.$pluginsService.validate(config.platformData, config.projectData);
 
 			const appDestinationDirectoryPath = path.join(config.platformData.appDestinationDirectoryPath, constants.APP_FOLDER_NAME);
@@ -64,9 +65,9 @@ export class PreparePlatformNativeService extends PreparePlatformService impleme
 			await this.$nodeModulesBuilder.prepareNodeModules({ nodeModulesData, release: config.appFilesUpdaterOptions.release });
 		}
 
-		if (!config.changesInfo || config.changesInfo.configChanged || config.changesInfo.modulesChanged) {
-			// Passing !shouldPrepareModules` we assume that if the node modules are prepared base Podfile content is added and `pod install` is executed.
-			await config.platformData.platformProjectService.processConfigurationFilesFromAppResources(config.projectData, {release:config.appFilesUpdaterOptions.release, installPods: !shouldPrepareModules});
+		if (hasModulesChange || hasConfigChange) {
+			await config.platformData.platformProjectService.processConfigurationFilesFromAppResources(config.projectData, { release: config.appFilesUpdaterOptions.release });
+			await config.platformData.platformProjectService.afterPrepareAllPlugins(config.projectData);
 		}
 
 		config.platformData.platformProjectService.interpolateConfigurationFile(config.projectData, config.platformSpecificData);

lib/tools/node-modules/node-modules-dest-copy.ts

@@ -112,11 +112,6 @@ export class NpmPluginPrepare {
 	}
 
 	protected async afterPrepare(dependencies: IDependencyData[], platform: string, projectData: IProjectData): Promise<void> {
-		await this.$platformsData.getPlatformData(platform, projectData).platformProjectService.afterPrepareAllPlugins(projectData);
-		this.writePreparedDependencyInfo(dependencies, platform, projectData);
-	}
-
-	private writePreparedDependencyInfo(dependencies: IDependencyData[], platform: string, projectData: IProjectData): void {
 		const prepareData: IDictionary<boolean> = {};
 		_.each(dependencies, d => {
 			prepareData[d.name] = true;

test/platform-service.ts

@@ -496,6 +496,7 @@ describe('Platform Service Tests', () => {
 							}
 						},
 						processConfigurationFilesFromAppResources: () => Promise.resolve(),
+						afterPrepareAllPlugins: () => Promise.resolve(),
 						ensureConfigurationFileInAppResources: (): any => null,
 						interpolateConfigurationFile: (): void => undefined,
 						isPlatformPrepared: (projectRoot: string) => false,
@@ -931,6 +932,7 @@ describe('Platform Service Tests', () => {
 						afterCreateProject: (projectRoot: string): any => null,
 						getAppResourcesDestinationDirectoryPath: () => testDirData.appResourcesFolderPath,
 						processConfigurationFilesFromAppResources: () => Promise.resolve(),
+						afterPrepareAllPlugins: () => Promise.resolve(),
 						ensureConfigurationFileInAppResources: (): any => null,
 						interpolateConfigurationFile: (): void => undefined,
 						isPlatformPrepared: (projectRoot: string) => false,