Merge pull request #4203 from NativeScript/vladimirov/track-accept-tracking

feat: add tracking for answer is we can track

Author: rosen-vladimirov

lib/constants.ts

@@ -150,7 +150,8 @@ export const enum TrackActionNames {
 	RunSetupScript = "Run Setup Script",
 	CheckLocalBuildSetup = "Check Local Build Setup",
 	CheckEnvironmentRequirements = "Check Environment Requirements",
-	Options = "Options"
+	Options = "Options",
+	AcceptTracking = "Accept Tracking"
 }
 
 export const AnalyticsEventLabelDelimiter = "__";

lib/services/analytics/analytics-service.ts

@@ -3,6 +3,7 @@ import * as path from "path";
 import { cache } from "../../common/decorators";
 import { isInteractive, toBoolean } from '../../common/helpers';
 import { DeviceTypes, AnalyticsClients } from "../../common/constants";
+import { TrackActionNames } from "../../constants";
 
 export class AnalyticsService implements IAnalyticsService, IDisposable {
 	private static ANALYTICS_BROKER_START_TIMEOUT = 10 * 1000;
@@ -72,10 +73,14 @@ export class AnalyticsService implements IAnalyticsService, IDisposable {
 	}
 
 	public async trackAcceptFeatureUsage(settings: { acceptTrackFeatureUsage: boolean }): Promise<void> {
-		await this.sendMessageToBroker(<IAcceptUsageReportingInformation>{
-			type: TrackingTypes.AcceptTrackFeatureUsage,
-			acceptTrackFeatureUsage: settings.acceptTrackFeatureUsage
-		});
+		const acceptTracking = !!(settings && settings.acceptTrackFeatureUsage);
+		const googleAnalyticsEventData: IGoogleAnalyticsEventData = {
+			googleAnalyticsDataType: GoogleAnalyticsDataType.Event,
+			action: TrackActionNames.AcceptTracking,
+			label: acceptTracking.toString()
+		};
+
+		await this.forcefullyTrackInGoogleAnalytics(googleAnalyticsEventData);
 	}
 
 	public async trackInGoogleAnalytics(gaSettings: IGoogleAnalyticsData): Promise<void> {

lib/services/analytics/analytics.d.ts

@@ -8,16 +8,6 @@ interface ITrackingInformation {
 	type: TrackingTypes
 }
 
-/**
- * Describes if the user allows to be tracked.
- */
-interface IAcceptUsageReportingInformation extends ITrackingInformation {
-	/**
-	 * The answer of the question if user allows us to track them.
-	 */
-	acceptTrackFeatureUsage: boolean;
-}
-
 /**
  * Describes information for exception that should be tracked.
  */