refactor: remove the emulator debug option

Author: DimitarTachev

lib/definitions/debug.d.ts

@@ -43,12 +43,6 @@ interface IDebugOptions {
 	 */
 	stop?: boolean;
 
-	// TODO: remove
-	/**
-	 * Defines if debug process is for emulator (not for real device).
-	 */
-	emulator?: boolean;
-
 	/**
 	 * Defines if the debug process should break on the first line.
 	 */

lib/services/android-debug-service.ts

@@ -26,7 +26,7 @@ export class AndroidDebugService extends DebugServiceBase implements IPlatformDe
 
 	public async debug(debugData: IDebugData, debugOptions: IDebugOptions): Promise<string> {
 		this._packageName = debugData.applicationIdentifier;
-		const result = debugOptions.emulator
+		const result = this.device.isEmulator
 			? await this.debugOnEmulator(debugData, debugOptions)
 			: await this.debugOnDevice(debugData, debugOptions);
 
@@ -108,7 +108,7 @@ export class AndroidDebugService extends DebugServiceBase implements IPlatformDe
 	private async debugOnDevice(debugData: IDebugData, debugOptions: IDebugOptions): Promise<string> {
 		let packageFile = "";
 
-		if (!debugOptions.start && !debugOptions.emulator) {
+		if (!debugOptions.start && !this.device.isEmulator) {
 			packageFile = debugData.pathToAppPackage;
 			this.$logger.out("Using ", packageFile);
 		}

lib/services/debug-service.ts

@@ -57,9 +57,7 @@ export class DebugService extends EventEmitter implements IDebugService {
 				this.$errors.failWithoutHelp("To debug on iOS simulator you need to provide path to the app package.");
 			}
 
-			if (this.$hostInfo.isWindows) {
-				debugOptions.emulator = false;
-			} else if (!this.$hostInfo.isDarwin) {
+			if (!this.$hostInfo.isWindows && !this.$hostInfo.isDarwin) {
 				this.$errors.failWithoutHelp(`Debugging on iOS devices is not supported for ${platform()} yet.`);
 			}
 		}