Merge pull request #4915 from NativeScript/fatme/fix-appstore-list

fix: fix appstore list command for accounts with 2fa

Author: Dimitar Tachev

lib/commands/appstore-upload.ts

@@ -42,7 +42,8 @@ export class PublishIOS implements ICommand {
 		const user = await this.$applePortalSessionService.createUserSession({ username, password }, {
 			applicationSpecificPassword:  this.$options.appleApplicationSpecificPassword,
 			sessionBase64: this.$options.appleSessionBase64,
-			requireInteractiveConsole: true
+			requireInteractiveConsole: true,
+			requireApplicationSpecificPassword: true
 		});
 		if (!user.areCredentialsValid) {
 			this.$errors.failWithoutHelp(`Invalid username and password combination. Used '${username}' as the username.`);

lib/services/apple-portal/apple-portal-session-service.ts

@@ -96,7 +96,8 @@ export class ApplePortalSessionService implements IApplePortalSessionService {
 				const statusCode = err && err.response && err.response.statusCode;
 				result.areCredentialsValid = statusCode !== 401 && statusCode !== 403;
 				result.isTwoFactorAuthenticationEnabled = statusCode === 409;
-				if (result.isTwoFactorAuthenticationEnabled && opts && !opts.applicationSpecificPassword) {
+
+				if (result.isTwoFactorAuthenticationEnabled && opts && opts.requireApplicationSpecificPassword && !opts.applicationSpecificPassword) {
 					this.$errors.failWithoutHelp(`Your account has two-factor authentication enabled but --appleApplicationSpecificPassword option is not provided.
 To generate an application-specific password, please go to https://appleid.apple.com/account/manage.
 This password will be used for the iTunes Transporter, which is used to upload your application.`);

lib/services/apple-portal/definitions.d.ts

@@ -19,6 +19,7 @@ interface IAppleCreateUserSessionOptions {
 	applicationSpecificPassword?: string;
 	sessionBase64: string;
 	requireInteractiveConsole?: boolean;
+	requireApplicationSpecificPassword?: boolean;
 }
 
 interface IAppleLoginResult {