fix: fix PR comments

Author: Fatme

lib/declarations.d.ts

@@ -761,7 +761,7 @@ interface IiOSNotification extends NodeJS.EventEmitter {
 
 interface IiOSSocketRequestExecutor {
 	executeAttachRequest(device: Mobile.IiOSDevice, timeout: number, projectId: string): Promise<void>;
-	executeRefreshRequest(device: Mobile.IiOSDevice, appId: string): Promise<boolean>;
+	executeRefreshRequest(device: Mobile.IiOSDevice, timeout: number, appId: string): Promise<boolean>;
 }
 
 /**

lib/device-sockets/ios/socket-request-executor.ts

@@ -12,24 +12,23 @@ export class IOSSocketRequestExecutor implements IiOSSocketRequestExecutor {
 		await this.executeRequest(mainRequestName, readyRequestName, appId, deviceId, timeout);
 	}
 
-	public async executeRefreshRequest(device: Mobile.IiOSDevice, appId: string): Promise<boolean> {
+	public async executeRefreshRequest(device: Mobile.IiOSDevice, timeout: number, appId: string): Promise<boolean> {
 		const deviceId = device.deviceInfo.identifier;
 		const mainRequestName = this.$iOSNotification.getRefreshRequest(appId);
-		const readyRequestName = this.$iOSNotification.getAppRefreshStarted(appId);
-		const timeout = 5;
+		const refreshRequestStartedName = this.$iOSNotification.getAppRefreshStarted(appId);
 
-		const result = await this.executeRequest(mainRequestName, readyRequestName, appId, deviceId, timeout);
+		const result = await this.executeRequest(mainRequestName, refreshRequestStartedName, appId, deviceId, timeout);
 
 		return result;
 	}
 
-	private async executeRequest(mainRequestName: string, readyRequestName: string, appId: string, deviceId: string, timeout: number): Promise<boolean> {
+	private async executeRequest(mainRequestName: string, successfulyExecutedNotificationName: string, appId: string, deviceId: string, timeout: number): Promise<boolean> {
 		let isSuccessful = false;
 
 		try {
 			// We should create this promise here because we need to send the ObserveNotification on the device
 			// before we send the PostNotification.
-			const socket = await this.$iOSNotificationService.postNotification(deviceId, readyRequestName, constants.IOS_OBSERVE_NOTIFICATION_COMMAND_TYPE);
+			const socket = await this.$iOSNotificationService.postNotification(deviceId, successfulyExecutedNotificationName, constants.IOS_OBSERVE_NOTIFICATION_COMMAND_TYPE);
 			const notificationPromise = this.$iOSNotificationService.awaitNotification(deviceId, +socket, timeout);
 			await this.$iOSNotificationService.postNotification(deviceId, mainRequestName);
 			await notificationPromise;

lib/services/livesync/ios-device-livesync-service.ts

@@ -116,7 +116,7 @@ export class IOSDeviceLiveSyncService extends DeviceLiveSyncServiceBase implemen
 	private async refreshWithNotification(projectData: IProjectData) {
 		let didRefresh = false;
 		await this.$lockService.executeActionWithLock(async () => {
-			didRefresh = await this.$iOSSocketRequestExecutor.executeRefreshRequest(this.device, projectData.projectIdentifiers.ios);
+			didRefresh = await this.$iOSSocketRequestExecutor.executeRefreshRequest(this.device, 5, projectData.projectIdentifiers.ios);
 		}, `ios-device-livesync-${this.device.deviceInfo.identifier}-${projectData.projectIdentifiers.ios}.lock`);
 
 		return didRefresh;