fix: no way to control watchos deployment target

Author: KristianDD

lib/services/ios-extensions-service.ts

@@ -33,12 +33,13 @@ export class IOSExtensionsService extends NativeTargetServiceBase implements IIO
 
 	private configureTarget(extensionName: string, extensionPath: string, target: IXcode.target, project: IXcode.project, projectData: IProjectData) {
 		const extJsonPath = path.join(extensionPath, "extension.json");
-		this.setConfigurationsFromJsonFile(extJsonPath, target.uuid, project);
 
 		this.setXcodeTargetBuildConfigurationProperties(
 			[{name: "PRODUCT_BUNDLE_IDENTIFIER", value: `${projectData.projectIdentifiers.ios}.${extensionName}`}],
 			extensionName,
 			project);
+
+		this.setConfigurationsFromJsonFile(extJsonPath, target.uuid, extensionName, project);
 	}
 
 	public removeExtensions({pbxProjPath}: IRemoveExtensionsOptions): void {

lib/services/ios-native-target-service-base.ts

@@ -71,17 +71,25 @@ export abstract class NativeTargetServiceBase implements IIOSNativeTargetService
 		});
 	}
 
-	protected setConfigurationsFromJsonFile(jsonPath: string, targetUuid: string, project: IXcode.project) {
+	protected setConfigurationsFromJsonFile(jsonPath: string, targetUuid: string, targetName: string, project: IXcode.project) {
 		if (this.$fs.exists(jsonPath)) {
 			const configurationJson = this.$fs.readJson(jsonPath) || {};
+
 			_.forEach(configurationJson.frameworks, framework => {
 				project.addFramework(
 					framework,
 					{ target: targetUuid }
 				);
 			});
+
 			if (configurationJson.assetcatalogCompilerAppiconName) {
-				project.addToBuildSettings("ASSETCATALOG_COMPILER_APPICON_NAME", configurationJson.assetcatalogCompilerAppiconName, targetUuid);
+				project.addToBuildSettings("ASSETCATALOG_COMPILER_APPICON_NAME", configurationJson.assetcatalogCompilerAppiconName,  targetUuid);
+			}
+
+			if (configurationJson.targetBuildConfigurationProperties) {
+				const properties: IXcodeTargetBuildConfigurationProperty[] = [];
+				_.forEach(configurationJson.targetBuildConfigurationProperties, (value, name: string) => properties.push({value, name}));
+				this.setXcodeTargetBuildConfigurationProperties(properties, targetName, project);
 			}
 		}
 	}

lib/services/ios-watch-app-service.ts

@@ -64,7 +64,6 @@ export class IOSWatchAppService extends NativeTargetServiceBase implements IIOSW
 
 	private configureTarget(targetName: string, targetPath: string, identifier: string, configurationFileName: string, target: IXcode.target, project: IXcode.project) {
 		const targetConfigurationJsonPath = path.join(targetPath, configurationFileName);
-		this.setConfigurationsFromJsonFile(targetConfigurationJsonPath, target.uuid, project);
 
 		const identifierParts = identifier.split(".");
 		identifierParts.pop();
@@ -74,10 +73,11 @@ export class IOSWatchAppService extends NativeTargetServiceBase implements IIOSW
 			{name: "PRODUCT_BUNDLE_IDENTIFIER", value: identifier},
 			{name: "SDKROOT", value: "watchos"},
 			{name: "TARGETED_DEVICE_FAMILY", value: IOSDeviceTargets.watchos},
-			{name: "WATCHOS_DEPLOYMENT_TARGET", value: 4.1}, //TODO consider WATCHOS_DEPLOYMENT_TARGET in json configuration
+			{name: "WATCHOS_DEPLOYMENT_TARGET", value: 5.2},
 			{name: "WK_APP_BUNDLE_IDENTIFIER", value: wkAppBundleIdentifier}
 		], targetName, project);
 
+		this.setConfigurationsFromJsonFile(targetConfigurationJsonPath, target.uuid, targetName, project);
 		project.addToHeaderSearchPaths(targetPath, target.pbxNativeTarget.productName);
 	}
 }