fix: do not validate invalid platforms versions

Author: DimitarTachev

lib/controllers/migrate-controller.ts

@@ -26,6 +26,7 @@ Running this command will ${MigrateController.COMMON_MIGRATE_MESSAGE}`;
 		private $addPlatformService: IAddPlatformService,
 		private $pluginsService: IPluginsService,
 		private $projectDataService: IProjectDataService,
+		private $platformValidationService: IPlatformValidationService,
 		private $resources: IResourceLoader) {
 		super($fs, $platformCommandHelper, $platformsDataService, $packageInstallationManager, $packageManager, $pacoteService);
 	}
@@ -159,6 +160,9 @@ Running this command will ${MigrateController.COMMON_MIGRATE_MESSAGE}`;
 
 		for (let platform of platforms) {
 			platform = platform && platform.toLowerCase();
+			if (!this.$platformValidationService.isValidPlatform(platform, projectData)) {
+				continue;
+			}
 
 			const hasRuntimeDependency = this.hasRuntimeDependency({ platform, projectData });
 			if (hasRuntimeDependency && await this.shouldUpdateRuntimeVersion(this.verifiedPlatformVersions[platform.toLowerCase()], platform, projectData, allowInvalidVersions)) {

lib/declarations.d.ts

@@ -1021,6 +1021,11 @@ interface IPlatformValidationService {
 	 */
 	validatePlatform(platform: string, projectData: IProjectData): void;
 
+	/**
+	 * Returns whether the passed platform is a valid one (from the supported ones)
+	 */
+	isValidPlatform(platform: string, projectData: IProjectData): boolean;
+
 	/**
 	 * Gets first chance to validate the options provided as command line arguments.
 	 * If no platform is provided or a falsy (null, undefined, "", false...) platform is provided,

lib/services/platform/platform-validation-service.ts

@@ -11,14 +11,25 @@ export class PlatformValidationService implements IPlatformValidationService {
 		private $platformsDataService: IPlatformsDataService
 	) { }
 
-	public validatePlatform(platform: string, projectData: IProjectData): void {
+	public isValidPlatform(platform: string, projectData: IProjectData): boolean {
 		if (!platform) {
-			this.$errors.fail("No platform specified.");
+			return false;
 		}
 
 		platform = platform.split("@")[0].toLowerCase();
-
 		if (!this.$platformsDataService.getPlatformData(platform, projectData)) {
+			return false;
+		}
+
+		return true;
+	}
+
+	public validatePlatform(platform: string, projectData: IProjectData): void {
+		if (!platform) {
+			this.$errors.fail("No platform specified.");
+		}
+
+		if (!this.isValidPlatform(platform, projectData)) {
 			const platformNames = helpers.formatListOfNames(this.$mobileHelper.platformNames);
 			this.$errors.fail(`Invalid platform ${platform}. Valid platforms are ${platformNames}.`);
 		}