Merge pull request #1134 from NativeScript/fatme/fix-pod-install

Fail if sandbox install command fails

Author: Mitko-Kerezov

lib/common

@@ -514,7 +514,27 @@ export class IOSProjectService extends projectServiceBaseLib.PlatformProjectServ
 
 			this.$logger.info("Installing pods...");
 			let podTool = this.$config.USE_POD_SANDBOX ? "sandbox-pod" : "pod";
-			return this.$childProcess.spawnFromEvent(podTool,  ["install"], "close", { cwd: this.platformData.projectRoot, stdio: 'inherit' }).wait();
+			let childProcess = this.$childProcess.spawnFromEvent(podTool,  ["install"], "close", { cwd: this.platformData.projectRoot, stdio: ['pipe', process.stdout, 'pipe'] }).wait();
+			if (childProcess.stderr) {
+				let warnings = childProcess.stderr.match(/(\u001b\[(?:\d*;){0,5}\d*m[\s\S]+?\u001b\[(?:\d*;){0,5}\d*m)|(\[!\].*?\n)/g);
+				_.each(warnings, (warning: string) => {
+					this.$logger.warnWithLabel(warning.replace("\n", ""));
+				});
+
+				// HACK for silencing irrelevant linking warnings when pod installing on
+				// El Capitan with cocoa pods version 0.38.2
+				// Reference https://github.com/CocoaPods/CocoaPods/issues/4302
+				let errors = childProcess.stderr.replace(/dyld: warning, LC_RPATH @executable_path.*?@executable_path/g, "");
+				_.each(warnings, warning => {
+					errors = errors.replace(warning, "");
+				});
+
+				if(errors.trim()) {
+					this.$errors.failWithoutHelp(`Pod install command failed. Error output: ${errors}`);
+				}
+			}
+
+			return childProcess;
 		}).future<any>()();
 	}
 

lib/services/ios-project-service.ts

@@ -209,7 +209,7 @@ export class PlatformService implements IPlatformService {
 			} catch(error) {
 				this.$logger.debug(error);
 				shell.rm("-rf", appResourcesDirectoryPath);
-				this.$errors.fail(`Processing node_modules failed. Error:${error}`);
+				this.$errors.failWithoutHelp(`Processing node_modules failed. ${error}`);
 			}
 
 			// Process platform specific files

lib/services/platform-service.ts

@@ -11,6 +11,7 @@ export class LoggerStub implements ILogger {
 	fatal(...args: string[]): void {}
 	error(...args: string[]): void {}
 	warn(...args: string[]): void {}
+	warnWithLabel(...args: string[]): void {}
 	info(...args: string[]): void {}
 	debug(...args: string[]): void {}
 	trace(...args: string[]): void {}