fix: project parsed once and overrides previous target

Author: KristianDD

lib/definitions/project.d.ts

@@ -579,11 +579,9 @@ interface IAddExtensionsFromPathOptions{
 	projectData: IProjectData;
 	platformData: IPlatformData;
 	pbxProjPath: string;
-	project: IXcode.project;
 }
 
 interface IRemoveExtensionsOptions {
-	project: IXcode.project;
 	pbxProjPath: string
 }
 

lib/services/ios-extensions-service.ts

@@ -2,15 +2,17 @@ import * as path from "path";
 
 export class IOSExtensionsService implements IIOSExtensionsService {
 	constructor(private $fs: IFileSystem,
-		private $pbxprojDomXcode: IPbxprojDomXcode) {
+		private $pbxprojDomXcode: IPbxprojDomXcode,
+		private $xcode: IXcode) {
 	}
 
-	public async addExtensionsFromPath({extensionsFolderPath, projectData, platformData, pbxProjPath, project}: IAddExtensionsFromPathOptions): Promise<void> {
+	public async addExtensionsFromPath({extensionsFolderPath, projectData, platformData, pbxProjPath}: IAddExtensionsFromPathOptions): Promise<void> {
 		const targetUuids: string[] = [];
 		if (!this.$fs.exists(extensionsFolderPath)) {
 			return;
 		}
-
+		const project = new this.$xcode.project(pbxProjPath);
+		project.parseSync();
 		this.$fs.readDirectory(extensionsFolderPath)
 			.filter(fileName => {
 				const filePath = path.join(extensionsFolderPath, fileName);
@@ -79,7 +81,9 @@ export class IOSExtensionsService implements IIOSExtensionsService {
 		xcode.save();
 	}
 
-	public removeExtensions({project, pbxProjPath}: IRemoveExtensionsOptions): void {
+	public removeExtensions({pbxProjPath}: IRemoveExtensionsOptions): void {
+		const project = new this.$xcode.project(pbxProjPath);
+		project.parseSync();
 		project.removeTargetsByProductType("com.apple.product-type.app-extension");
 		this.$fs.writeFile(pbxProjPath, project.writeSync({omitEmptyValues: true}));
 	}

lib/services/ios-project-service.ts

@@ -984,8 +984,7 @@ We will now place an empty obsolete compatability white screen LauncScreen.xib f
 		}
 
 		const pbxProjPath = this.getPbxProjPath(projectData);
-		const project = this.createPbxProj(projectData);
-		this.$iOSExtensionsService.removeExtensions({project, pbxProjPath});
+		this.$iOSExtensionsService.removeExtensions({pbxProjPath});
 		await this.addExtensions(projectData);
 	}
 	public beforePrepareAllPlugins(): Promise<void> {
@@ -1109,15 +1108,14 @@ We will now place an empty obsolete compatability white screen LauncScreen.xib f
 		);
 		const platformData = this.getPlatformData(projectData);
 		const pbxProjPath = this.getPbxProjPath(projectData);
-		const project = this.createPbxProj(projectData);
-		await this.$iOSExtensionsService.addExtensionsFromPath({extensionsFolderPath: resorcesExtensionsPath, projectData, platformData, pbxProjPath, project});
+		await this.$iOSExtensionsService.addExtensionsFromPath({extensionsFolderPath: resorcesExtensionsPath, projectData, platformData, pbxProjPath});
 		const plugins = await this.getAllInstalledPlugins(projectData);
 		for (const pluginIndex in plugins) {
 			const pluginData = plugins[pluginIndex];
 			const pluginPlatformsFolderPath = pluginData.pluginPlatformsFolderPath(IOSProjectService.IOS_PLATFORM_NAME);
 
 			const extensionPath = path.join(pluginPlatformsFolderPath, constants.NATIVE_EXTENSION_FOLDER);
-			await this.$iOSExtensionsService.addExtensionsFromPath({extensionsFolderPath: extensionPath, projectData, platformData, pbxProjPath, project});
+			await this.$iOSExtensionsService.addExtensionsFromPath({extensionsFolderPath: extensionPath, projectData, platformData, pbxProjPath});
 		}
 	}