fix: use correct method for showing all warnings on initialize

Author: rosen-vladimirov

lib/common/verify-node-version.ts

@@ -53,38 +53,43 @@ export function verifyNodeVersion(): void {
 	}
 }
 
+var isGetNodeWarningCalled = false;
 export function getNodeWarning(): ISystemWarning {
-	var verificationOpts = getNodeVersionOpts();
-	var cliName = verificationOpts.cliName;
-	var supportedVersionsRange = verificationOpts.supportedVersionsRange;
-	var deprecatedVersions = verificationOpts.deprecatedVersions;
-	var nodeVer = verificationOpts.nodeVer;
+	if (!isGetNodeWarningCalled) {
+		isGetNodeWarningCalled = true;
+
+		var verificationOpts = getNodeVersionOpts();
+		var cliName = verificationOpts.cliName;
+		var supportedVersionsRange = verificationOpts.supportedVersionsRange;
+		var deprecatedVersions = verificationOpts.deprecatedVersions;
+		var nodeVer = verificationOpts.nodeVer;
 
-	var warningMessage = "";
-	if (deprecatedVersions) {
-		deprecatedVersions.forEach(function (version) {
-			if (semver.satisfies(nodeVer, version)) {
-				warningMessage = "Support for Node.js " + version + " is deprecated and will be removed in one of the next releases of " + cliName +
-					". Please, upgrade to the latest Node.js LTS version. ";
-				return warningMessage;
+		var warningMessage = "";
+		if (deprecatedVersions) {
+			deprecatedVersions.forEach(function (version) {
+				if (semver.satisfies(nodeVer, version)) {
+					warningMessage = "Support for Node.js " + version + " is deprecated and will be removed in one of the next releases of " + cliName +
+						". Please, upgrade to the latest Node.js LTS version. ";
+					return warningMessage;
+				}
+			});
+		}
+
+		if (!warningMessage) {
+			var checkSatisfied = semver.satisfies(nodeVer, supportedVersionsRange);
+			if (!checkSatisfied) {
+				warningMessage = "Support for Node.js " + nodeVer + " is not verified. " + cliName + " CLI might not install or run properly.";
 			}
-		});
-	}
+		}
 
-	if (!warningMessage) {
-		var checkSatisfied = semver.satisfies(nodeVer, supportedVersionsRange);
-		if (!checkSatisfied) {
-			warningMessage = "Support for Node.js " + nodeVer + " is not verified. " + cliName + " CLI might not install or run properly.";
+		if (warningMessage) {
+			return {
+				message: warningMessage,
+				severity: SystemWarningsSeverity.medium
+			};
 		}
-	}
 
-	if (warningMessage) {
-		return {
-			message: warningMessage,
-			severity: SystemWarningsSeverity.medium
-		};
+		return null;
 	}
-
-	return null;
 }
 /* tslint:enable */

lib/services/initialize-service.ts

@@ -15,15 +15,15 @@ export class InitializeService implements IInitializeService {
 
 	private async showWarnings($logger: ILogger): Promise<void> {
 		const $sysInfo = $injector.resolve<ISysInfo>("sysInfo");
-		const macOSWarning = await $sysInfo.getMacOSWarningMessage();
-		if (macOSWarning) {
-			const message = `${EOL}${macOSWarning.message}${EOL}`;
-			if (macOSWarning.severity === SystemWarningsSeverity.high) {
+		const systemWarnings = await $sysInfo.getSystemWarnings();
+		_.each(systemWarnings, systemWarning => {
+			const message = `${EOL}${systemWarning.message}${EOL}`;
+			if (systemWarning.severity === SystemWarningsSeverity.high) {
 				$logger.printOnStderr(message.red.bold);
 			} else {
 				$logger.warn(message);
 			}
-		}
+		});
 	}
 }