Merge pull request #3635 from NativeScript/fatme/fix-depracated-buffer

fix: fix a deprecation warning that is shown when debug command is executed using node v10

Author: Fatme

lib/device-sockets/ios/packet-stream.ts

@@ -13,7 +13,7 @@ export class PacketStream extends stream.Transform {
 			if (!this.buffer) {
 				// read length
 				const length = packet.readInt32BE(0);
-				this.buffer = new Buffer(length);
+				this.buffer = Buffer.allocUnsafe(length);
 				this.offset = 0;
 				packet = packet.slice(4);
 			}

lib/device-sockets/ios/socket-proxy-factory.ts

@@ -124,7 +124,7 @@ export class SocketProxyFactory extends EventEmitter implements ISocketProxyFact
 
 			webSocket.on("message", (message: string) => {
 				const length = Buffer.byteLength(message, encoding);
-				const payload = new Buffer(length + 4);
+				const payload = Buffer.allocUnsafe(length + 4);
 				payload.writeInt32BE(length, 0);
 				payload.write(message, 4, length, encoding);
 				deviceSocket.write(payload);

lib/services/livesync/android-device-livesync-service.ts

@@ -129,7 +129,7 @@ export class AndroidDeviceLiveSyncService extends DeviceLiveSyncServiceBase impl
 			const socket = new net.Socket();
 
 			socket.connect(this.port, '127.0.0.1', () => {
-				socket.write(new Buffer([0, 0, 0, 1, 1]));
+				socket.write(Buffer.from([0, 0, 0, 1, 1]));
 			});
 			socket.on("data", (data: any) => {
 				isResolved = true;

lib/services/livesync/ios-device-livesync-service.ts

@@ -135,7 +135,7 @@ export class IOSDeviceLiveSyncService extends DeviceLiveSyncServiceBase implemen
 			await new Promise<void>((resolve, reject) => {
 				let isResolved = false;
 				const length = Buffer.byteLength(message, "utf16le");
-				const payload = new Buffer(length + 4);
+				const payload = Buffer.allocUnsafe(length + 4);
 				payload.writeInt32BE(length, 0);
 				payload.write(message, 4, length, "utf16le");