More code review changes

Author: Fatme

lib/constants.ts

@@ -4,5 +4,5 @@ export var APP_FOLDER_NAME = "app";
 export var DEFAULT_PROJECT_ID = "com.telerik.tns.HelloWorld";
 export var DEFAULT_PROJECT_NAME = "HelloNativescript";
 export var APP_RESOURCES_FOLDER_NAME = "App_Resources";
-export var PROJECT_FRAMEWORK_DIR = "framework";
+export var PROJECT_FRAMEWORK_FOLDER_NAME = "framework";
 

lib/definitions/shelljs.d.ts

@@ -1,5 +1,6 @@
 declare module "shelljs" {
-	function cp(arg: string, sourcePath: any, destinationPath: string): void;
+	function cp(arg: string, sourcePath: string, destinationPath: string): void;
+	function cp(arg: string, sourcePath: string[], destinationPath: string): void;
 	function sed(arg: string, oldValue: any, newValue: string, filePath: string): void;
 	function mv(source: string[], destination: string);
 	function grep(what: any, where: string): any;

lib/node-package-manager.ts

@@ -30,12 +30,13 @@ export class NodePackageManager implements INodePackageManager {
 	public install(packageName: string, pathToSave?: string): IFuture<string> {
 		return (() => {
 			var action = (packageName: string) => {
-				this.installCore(pathToSave || npm.cache, packageName).wait();
+				pathToSave = pathToSave || npm.cache;
+				this.installCore(pathToSave, packageName).wait();
 			};
 
 			this.tryExecuteAction(action, packageName).wait();
 
-			return path.join(pathToSave || npm.cache, "node_modules", packageName);
+			return path.join(pathToSave, "node_modules", packageName);
 
 		}).future<string>()();
 	}

lib/services/platform-service.ts

@@ -103,7 +103,7 @@ export class PlatformService implements IPlatformService {
 			// get path to downloaded framework package
 			var frameworkDir = this.$npm.install(this.$platformsData.getPlatformData(platform).frameworkPackageName,
 				path.join(this.$projectData.platformsDir, platform)).wait();
-			frameworkDir = path.join(frameworkDir, constants.PROJECT_FRAMEWORK_DIR);
+			frameworkDir = path.join(frameworkDir, constants.PROJECT_FRAMEWORK_FOLDER_NAME);
 
 			platformProjectService.createProject(platformData.projectRoot, frameworkDir).wait();