Merge pull request #2138 from NativeScript/pete/plugin-check-deps-v8

Check if plugin consumes v8 symbols

Author: enchev

lib/definitions/project.d.ts

@@ -86,7 +86,7 @@ interface IPlatformProjectService {
 	preparePluginNativeCode(pluginData: IPluginData, options?: any): IFuture<void>;
 	removePluginNativeCode(pluginData: IPluginData): IFuture<void>;
 	afterPrepareAllPlugins(): IFuture<void>;
-	beforePrepareAllPlugins(): IFuture<void>;
+	beforePrepareAllPlugins(dependencies?: IDictionary<IDependencyData>): IFuture<void>;
 	getAppResourcesDestinationDirectoryPath(): IFuture<string>;
 	deploy(deviceIdentifier: string): IFuture<void>;
 	processConfigurationFilesFromAppResources(): IFuture<void>;

lib/services/android-project-service.ts

@@ -393,8 +393,18 @@ export class AndroidProjectService extends projectServiceBaseLib.PlatformProject
 		return Future.fromResult();
 	}
 
-	public beforePrepareAllPlugins(): IFuture<void> {
+	public beforePrepareAllPlugins(dependencies?: IDictionary<IDependencyData>): IFuture<void> {
 		if (!this.$config.debugLivesync) {
+			if (dependencies) {
+				let platformDir = path.join(this.$projectData.platformsDir, "android");
+				let buildDir = path.join(platformDir, "build-tools");
+				let checkV8dependants = path.join(buildDir, "check-v8-dependants.js");
+				if (this.$fs.exists(checkV8dependants).wait()) {
+					let stringifiedDependencies = JSON.stringify(dependencies);
+					this.spawn('node', [checkV8dependants, stringifiedDependencies, this.$projectData.platformsDir], { stdio: "inherit" }).wait();
+				}
+			}
+
 			let buildOptions = this.getBuildOptions();
 
 			buildOptions.unshift("clean");

lib/tools/node-modules/node-modules-dest-copy.ts

@@ -142,7 +142,8 @@ export class NpmPluginPrepare {
 			return;
 		}
 
-		this.$platformsData.getPlatformData(platform).platformProjectService.beforePrepareAllPlugins().wait();
+		this.$platformsData.getPlatformData(platform).platformProjectService.beforePrepareAllPlugins(dependencies).wait();
+
 		_.each(dependencies, dependency => {
 			let isPlugin = !!dependency.nativescript;
 			if (isPlugin) {