fix(console): remove CONSOLE prefix - unnecessary

NathanWalker · NathanWalker · commit fea46b282213 · 2022-07-21T20:27:20.000-07:00
diff --git a/NativeScript/runtime/Console.cpp b/NativeScript/runtime/Console.cpp
@@ -35,6 +35,7 @@ void Console::Init(Local<Context> context) {
 }
 
 void Console::LogCallback(const FunctionCallbackInfo<Value>& args) {
+    // TODO: implement 'forceLog' override option like android has, to force logs in prod if desired
     if (!RuntimeConfig.LogToSystemConsole) {
         return;
     }
@@ -59,8 +60,8 @@ void Console::LogCallback(const FunctionCallbackInfo<Value>& args) {
 
     std::string level = VerbosityToInspectorVerbosity(verbosityLevel);
     v8_inspector::V8LogAgentImpl::EntryAdded(msgToLog, level, "", 0);
-    std::string msgWithVerbosity = "CONSOLE " + verbosityLevelUpper + ": " + msgToLog;
-    Log("%s", msgWithVerbosity.c_str());
+    // std::string msgWithVerbosity = "CONSOLE " + verbosityLevelUpper + ": " + msgToLog;
+    Log("%s", msgToLog.c_str());
 }
 
 void Console::AssertCallback(const FunctionCallbackInfo<Value>& args) {

Original file line number	Diff line number	Diff line change
`@@ -35,6 +35,7 @@ void Console::Init(Local<Context> context) {`
`35`	`35`	`}`
`36`	`36`
`37`	`37`	`void Console::LogCallback(const FunctionCallbackInfo<Value>& args) {`
	`38`	`+ // TODO: implement 'forceLog' override option like android has, to force logs in prod if desired`
`38`	`39`	`if (!RuntimeConfig.LogToSystemConsole) {`
`39`	`40`	`return;`
`40`	`41`	`}`
`@@ -59,8 +60,8 @@ void Console::LogCallback(const FunctionCallbackInfo<Value>& args) {`
`59`	`60`
`60`	`61`	`std::string level = VerbosityToInspectorVerbosity(verbosityLevel);`
`61`	`62`	`v8_inspector::V8LogAgentImpl::EntryAdded(msgToLog, level, "", 0);`
`62`		`- std::string msgWithVerbosity = "CONSOLE " + verbosityLevelUpper + ": " + msgToLog;`
`63`		`- Log("%s", msgWithVerbosity.c_str());`
	`63`	`+ // std::string msgWithVerbosity = "CONSOLE " + verbosityLevelUpper + ": " + msgToLog;`
	`64`	`+ Log("%s", msgToLog.c_str());`
`64`	`65`	`}`
`65`	`66`
`66`	`67`	`void Console::AssertCallback(const FunctionCallbackInfo<Value>& args) {`