feat: add debug runtime detail log handling

Author: NathanWalker

NativeScript/runtime/ArgConverter.mm

@@ -622,6 +622,9 @@
         std::string className = object_getClassName(target);
         auto it = cache->ClassPrototypes.find(className);
         if (it != cache->ClassPrototypes.end()) {
+            // for debugging rlv cell handling:
+            // NSString* message = [NSString stringWithFormat:@"ArgConverter::CreateJsWrapper FindMeta: class {%@}", NSStringFromClass(klass)];
+            // Log(@"%@", message);
             Local<Value> prototype = it->second->Get(isolate);
             bool success;
             if (!receiver->SetPrototype(context, prototype).To(&success) || !success) {

NativeScript/runtime/Interop.mm

@@ -1535,9 +1535,7 @@ void LogWriteValueTraceMessage(Local<Context> context, const TypeEncoding* typeE
 
 void Interop::ExecuteWriteValueDebugValidationsIfInDebug(Local<Context> context, const TypeEncoding* typeEncoding, void* dest, Local<Value> arg) {
 
-    if (!RuntimeConfig.IsDebug) {
-        return;
-    }
+    #ifdef DEBUG
     id value = Runtime::GetAppConfigValue("logRuntimeDetail");
     bool logRuntimeDetail = value ? [value boolValue] : false;
     if (logRuntimeDetail) {
@@ -1550,6 +1548,7 @@ void LogWriteValueTraceMessage(Local<Context> context, const TypeEncoding* typeE
         LogWriteValueTraceMessage(context, typeEncoding, dest, arg);
         ExecuteWriteValueValidationsAndStopExecutionAndLogStackTrace(context, typeEncoding, dest, arg);
     }
+    #endif
 }
 
 }

NativeScript/runtime/MetadataBuilder.mm

@@ -812,7 +812,7 @@
     Class klass = objc_getClass(containingClass.c_str());
     // TODO: Find out if the isMethodCallback property can be determined based on a UITableViewController.prototype.viewDidLoad.call(this) or super.viewDidLoad() call
 
-    if (RuntimeConfig.IsDebug) {
+    #ifdef DEBUG
         id value = Runtime::GetAppConfigValue("logRuntimeDetail");
         bool logRuntimeDetail = value ? [value boolValue] : false;
         if (logRuntimeDetail) {
@@ -825,7 +825,7 @@
                                 meta->topLevelModule()->getName()];
             Log(@"%@", message);
         }
-    }
+    #endif
 
     try {
         return ArgConverter::Invoke(context, klass, receiver, args, meta, isMethodCallback);