Skip to content

Commit 68843f8

Browse files
committed
NO-JIRA: update test_make_disable_pushing to use Python 3.12 image in test_main.py
1 parent f64d57b commit 68843f8

File tree

1 file changed

+4
-3
lines changed

1 file changed

+4
-3
lines changed

tests/test_main.py

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -33,8 +33,8 @@ def test_image_pipfiles(subtests: pytest_subtests.plugin.SubTests):
3333
def test_files_that_should_be_same_are_same(subtests: pytest_subtests.plugin.SubTests):
3434
file_groups = {
3535
"ROCm de-vendor script": [
36-
PROJECT_ROOT / "jupyter/rocm/pytorch/ubi9-python-3.11/de-vendor-torch.sh",
37-
PROJECT_ROOT / "runtimes/rocm-pytorch/ubi9-python-3.11/de-vendor-torch.sh",
36+
PROJECT_ROOT / "jupyter/rocm/pytorch/ubi9-python-3.12/de-vendor-torch.sh",
37+
PROJECT_ROOT / "runtimes/rocm-pytorch/ubi9-python-3.12/de-vendor-torch.sh",
3838
]
3939
}
4040
for group_name, (first_file, *rest) in file_groups.items():
@@ -44,7 +44,8 @@ def test_files_that_should_be_same_are_same(subtests: pytest_subtests.plugin.Sub
4444

4545

4646
def test_make_disable_pushing():
47-
lines = dryrun_make(["rocm-jupyter-tensorflow-ubi9-python-3.11"], env={"PUSH_IMAGES": ""})
47+
# NOTE: the image below needs to exist in the Makefile
48+
lines = dryrun_make(["rocm-jupyter-tensorflow-ubi9-python-3.12"], env={"PUSH_IMAGES": ""})
4849
for line in lines:
4950
assert "podman push" not in line
5051

0 commit comments

Comments
 (0)