Always use paths relative to the container root for links

This chagne ensures that we always treat the link path as a path
relative to the container root. Without this change, relative paths
in link paths would result links being created relative to the
current working directory where the hook is executed.

Signed-off-by: Evan Lezar <elezar@nvidia.com>

Author: elezar

cmd/nvidia-cdi-hook/create-symlinks/create-symlinks.go

@@ -108,13 +108,10 @@ func (m command) run(c *cli.Context, cfg *config) error {
 }
 
 func (m command) createLink(containerRoot string, targetPath string, link string) error {
-	linkPath, err := changeRoot(containerRoot, link)
-	if err != nil {
-		m.logger.Warningf("Failed to resolve path for link %v relative to %v: %v", link, containerRoot, err)
-	}
+	linkPath := filepath.Join(containerRoot, link)
 
 	m.logger.Infof("Symlinking %v to %v", linkPath, targetPath)
-	err = os.MkdirAll(filepath.Dir(linkPath), 0755)
+	err := os.MkdirAll(filepath.Dir(linkPath), 0755)
 	if err != nil {
 		return fmt.Errorf("failed to create directory: %v", err)
 	}
@@ -125,11 +122,3 @@ func (m command) createLink(containerRoot string, targetPath string, link string
 
 	return nil
 }
-
-func changeRoot(new string, path string) (string, error) {
-	if !filepath.IsAbs(path) {
-		return path, nil
-	}
-
-	return filepath.Join(new, path), nil
-}