Merge pull request #619 from NVIDIA/fix-mig-get-minor-number

cdesiniotis · web-flow · commit 87a63a615982 · 2024-07-22T15:21:49.000-07:00
[bugfix] Process error type instead of nvml.Return
diff --git a/internal/platform-support/dgpu/nvml.go b/internal/platform-support/dgpu/nvml.go
@@ -145,9 +145,9 @@ type toRequiredMigInfo struct {
 }
 
 func (d *toRequiredMigInfo) getPlacementInfo() (int, int, int, error) {
-	gpu, ret := d.parent.GetMinorNumber()
-	if ret != nvml.SUCCESS {
-		return 0, 0, 0, fmt.Errorf("error getting GPU minor: %v", ret)
+	gpu, err := d.parent.GetMinorNumber()
+	if err != nil {
+		return 0, 0, 0, fmt.Errorf("error getting GPU minor: %w", err)
 	}
 
 	gi, ret := d.GetGpuInstanceId()

Original file line number	Diff line number	Diff line change
`@@ -145,9 +145,9 @@ type toRequiredMigInfo struct {`
`145`	`145`	`}`
`146`	`146`
`147`	`147`	`func (d *toRequiredMigInfo) getPlacementInfo() (int, int, int, error) {`
`148`		`- gpu, ret := d.parent.GetMinorNumber()`
`149`		`- if ret != nvml.SUCCESS {`
`150`		`- return 0, 0, 0, fmt.Errorf("error getting GPU minor: %v", ret)`
	`148`	`+ gpu, err := d.parent.GetMinorNumber()`
	`149`	`+ if err != nil {`
	`150`	`+ return 0, 0, 0, fmt.Errorf("error getting GPU minor: %w", err)`
`151`	`151`	`}`
`152`	`152`
`153`	`153`	`gi, ret := d.GetGpuInstanceId()`