diff --git a/cmd/gpu-feature-discovery/main.go b/cmd/gpu-feature-discovery/main.go index 5590247df..c6a505efd 100644 --- a/cmd/gpu-feature-discovery/main.go +++ b/cmd/gpu-feature-discovery/main.go @@ -99,6 +99,7 @@ func main() { }, &cli.BoolFlag{ Name: "use-node-feature-api", + Value: true, Usage: "Use NFD NodeFeature API to publish labels", EnvVars: []string{"GFD_USE_NODE_FEATURE_API", "USE_NODE_FEATURE_API"}, }, diff --git a/deployments/helm/nvidia-device-plugin/templates/daemonset-gfd.yml b/deployments/helm/nvidia-device-plugin/templates/daemonset-gfd.yml index 09f9dfe39..99f27d9aa 100644 --- a/deployments/helm/nvidia-device-plugin/templates/daemonset-gfd.yml +++ b/deployments/helm/nvidia-device-plugin/templates/daemonset-gfd.yml @@ -15,7 +15,7 @@ {{- if .Values.gfd.enabled }} --- {{- $options := (include "nvidia-device-plugin.options" . | fromJson) }} -{{- $useServiceAccount := or ( $options.hasConfigMap ) ( and .Values.gfd.enabled .Values.nfd.enableNodeFeatureApi ) }} +{{- $useServiceAccount := or $options.hasConfigMap .Values.gfd.enabled }} {{- $configMapName := (include "nvidia-device-plugin.configMapName" .) | trim }} {{- $daemonsetName := printf "%s-gpu-feature-discovery" (include "nvidia-device-plugin.fullname" .) | trunc 63 | trimSuffix "-" }} apiVersion: apps/v1 @@ -161,10 +161,6 @@ spec: - name: GFD_SLEEP_INTERVAL value: {{ .Values.sleepInterval | quote }} {{- end }} - {{- if typeIs "bool" .Values.nfd.enableNodeFeatureApi }} - - name: GFD_USE_NODE_FEATURE_API - value: {{ .Values.nfd.enableNodeFeatureApi | quote }} - {{- end }} {{- if $options.hasConfigMap }} - name: CONFIG_FILE value: /config/config.yaml diff --git a/deployments/helm/nvidia-device-plugin/templates/role-binding.yml b/deployments/helm/nvidia-device-plugin/templates/role-binding.yml index 9232b1ed3..0bfdd0896 100644 --- a/deployments/helm/nvidia-device-plugin/templates/role-binding.yml +++ b/deployments/helm/nvidia-device-plugin/templates/role-binding.yml @@ -1,6 +1,6 @@ --- {{- $options := (include "nvidia-device-plugin.options" . | fromJson) }} -{{- if or $options.hasConfigMap ( and .Values.gfd.enabled .Values.nfd.enableNodeFeatureApi ) }} +{{- if or $options.hasConfigMap .Values.gfd.enabled }} apiVersion: rbac.authorization.k8s.io/v1 kind: ClusterRoleBinding metadata: diff --git a/deployments/helm/nvidia-device-plugin/templates/role.yml b/deployments/helm/nvidia-device-plugin/templates/role.yml index c2ecb803a..77353590c 100644 --- a/deployments/helm/nvidia-device-plugin/templates/role.yml +++ b/deployments/helm/nvidia-device-plugin/templates/role.yml @@ -1,6 +1,6 @@ --- {{- $options := (include "nvidia-device-plugin.options" . | fromJson) }} -{{- if or $options.hasConfigMap ( and .Values.gfd.enabled .Values.nfd.enableNodeFeatureApi ) }} +{{- if or $options.hasConfigMap .Values.gfd.enabled }} apiVersion: rbac.authorization.k8s.io/v1 kind: ClusterRole metadata: @@ -11,7 +11,7 @@ rules: - apiGroups: [""] resources: ["nodes"] verbs: ["get", "list", "watch"] - {{- if and .Values.gfd.enabled .Values.nfd.enableNodeFeatureApi }} + {{- if .Values.gfd.enabled }} - apiGroups: ["nfd.k8s-sigs.io"] resources: ["nodefeatures"] verbs: ["get", "list", "watch", "create", "update"] diff --git a/deployments/helm/nvidia-device-plugin/templates/service-account.yml b/deployments/helm/nvidia-device-plugin/templates/service-account.yml index 7ab9ba336..587d4578d 100644 --- a/deployments/helm/nvidia-device-plugin/templates/service-account.yml +++ b/deployments/helm/nvidia-device-plugin/templates/service-account.yml @@ -1,6 +1,6 @@ --- {{- $options := (include "nvidia-device-plugin.options" . | fromJson) }} -{{- if or $options.hasConfigMap ( and .Values.gfd.enabled .Values.nfd.enableNodeFeatureApi ) }} +{{- if or $options.hasConfigMap .Values.gfd.enabled }} apiVersion: v1 kind: ServiceAccount metadata: diff --git a/deployments/helm/nvidia-device-plugin/values.yaml b/deployments/helm/nvidia-device-plugin/values.yaml index 5953c77f8..a02688cfa 100644 --- a/deployments/helm/nvidia-device-plugin/values.yaml +++ b/deployments/helm/nvidia-device-plugin/values.yaml @@ -118,7 +118,6 @@ gfd: # Helm dependency nfd: nameOverride: node-feature-discovery - enableNodeFeatureApi: false master: serviceAccount: name: node-feature-discovery