resource: Fix resourceLabeler's sharingDisabled to check if a strategy is defined

danielkleinstein · danielkleinstein · commit 72b9e0bffa37 · 2024-10-28T16:39:07.000+02:00
Signed-off-by: Daniel Kleinstein &lt;daniel@scaleops.com&gt;
diff --git a/internal/lm/resource.go b/internal/lm/resource.go
@@ -215,7 +215,7 @@ func (rl resourceLabeler) getReplicas() int {
 // sharingDisabled checks whether the resourceLabeler has sharing disabled
 // TODO: The nil check here is because we call NewGPUResourceLabeler with a nil config when sharing is disabled.
 func (rl resourceLabeler) sharingDisabled() bool {
-	return rl.sharing == nil
+	return rl.sharing == nil || (rl.sharing.SharingStrategy() == spec.SharingStrategyNone)
 }
 
 // isShared checks whether the resource is shared.

Original file line number	Diff line number	Diff line change
`@@ -215,7 +215,7 @@ func (rl resourceLabeler) getReplicas() int {`
`215`	`215`	`// sharingDisabled checks whether the resourceLabeler has sharing disabled`
`216`	`216`	`// TODO: The nil check here is because we call NewGPUResourceLabeler with a nil config when sharing is disabled.`
`217`	`217`	`func (rl resourceLabeler) sharingDisabled() bool {`
`218`		`- return rl.sharing == nil`
	`218`	`+ return rl.sharing == nil \|\| (rl.sharing.SharingStrategy() == spec.SharingStrategyNone)`
`219`	`219`	`}`
`220`	`220`
`221`	`221`	`// isShared checks whether the resource is shared.`