Skip to content

Commit 62fcbfc

Browse files
Fix build problems for rockylinux
Signed-off-by: Martin Marciniszyn Mehringer <11665257+MartinMarciniszyn@users.noreply.github.com>
1 parent 69e8fd2 commit 62fcbfc

File tree

3 files changed

+13
-6
lines changed

3 files changed

+13
-6
lines changed

docker/Dockerfile.multi

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13,9 +13,10 @@ LABEL com.nvidia.eula="https://www.nvidia.com/en-us/agreements/enterprise-softwa
1313
LABEL com.nvidia.ai-terms="https://www.nvidia.com/en-us/agreements/enterprise-software/product-specific-terms-for-ai-products/"
1414

1515
# https://www.gnu.org/software/bash/manual/html_node/Bash-Startup-Files.html
16-
# The default values come from `nvcr.io/nvidia/pytorch`
17-
ENV BASH_ENV=${BASH_ENV:-/etc/bash.bashrc}
18-
ENV ENV=${ENV:-/etc/shinit_v2}
16+
ARG SH_ENV="/etc/shinit_v2"
17+
ENV ENV=${SH_ENV}
18+
ARG BASH_ENV="/etc/bash.bashrc"
19+
ENV BASH_ENV=${BASH_ENV}
1920

2021
ARG GITHUB_MIRROR=""
2122
RUN echo "Using GitHub mirror: $GITHUB_MIRROR"

docker/Makefile

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -56,6 +56,10 @@ NGC_STAGING_REPO ?= nvcr.io/nvstaging/tensorrt-llm
5656
NGC_REPO ?= nvcr.io/nvidia/tensorrt-llm
5757
NGC_USE_STAGING ?= 0
5858
NGC_AUTO_REPO ?= $(if $(filter 1,$(NGC_USE_STAGING)),$(NGC_STAGING_REPO),$(NGC_REPO))
59+
SH_ENV ?= $(shell docker inspect --format='{{range .Config.Env}}{{println .}}{{end}}' $(BASE_IMAGE):$(BASE_TAG) \
60+
| grep '^ENV=' | sed 's/^[^=]*=//' 2>/dev/null)
61+
BASH_ENV ?= $(shell docker inspect --format='{{range .Config.Env}}{{println .}}{{end}}' $(BASE_IMAGE):$(BASE_TAG) \
62+
| grep '^BASH_ENV=' | sed 's/^[^=]*=//' 2>/dev/null)
5963

6064
define add_local_user
6165
docker build \
@@ -97,6 +101,8 @@ endef
97101
$(if $(GIT_COMMIT), --build-arg GIT_COMMIT="$(GIT_COMMIT)") \
98102
$(if $(GITHUB_MIRROR), --build-arg GITHUB_MIRROR="$(GITHUB_MIRROR)") \
99103
$(if $(PYTHON_VERSION), --build-arg PYTHON_VERSION="$(PYTHON_VERSION)") \
104+
$(if $(SH_ENV), --build-arg SH_ENV="$(SH_ENV)") \
105+
$(if $(BASH_ENV), --build-arg BASH_ENV="$(BASH_ENV)") \
100106
$(if $(STAGE), --target $(STAGE)) \
101107
--file Dockerfile.multi \
102108
--tag $(IMAGE_WITH_TAG) \

docker/common/install.sh

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
#!/bin/bash
1+
#!/usr/bin/env bash
22
set -Eeo pipefail
33
shopt -s nullglob
44
trap 'echo "[install.sh] Error on line $LINENO" >&2' ERR
@@ -125,7 +125,7 @@ fi
125125

126126
if [ $opencv -eq 1 ]; then
127127
echo "Installing OpenCV..."
128-
pip3 uninstall -y opencv
128+
bash -c "pip3 uninstall -y opencv"
129129
rm -rf /usr/local/lib/python3*/dist-packages/cv2/
130-
pip3 install opencv-python-headless --force-reinstall --no-deps --no-cache-dir
130+
bash -c "pip3 install opencv-python-headless --force-reinstall --no-deps --no-cache-dir"
131131
fi

0 commit comments

Comments
 (0)