Skip to content

bug: Race conditions and deadlock possible in embeddings/basic.py #1476

@tgasser-nv

Description

@tgasser-nv

Did you check docs and existing issues?

  • I have read all the NeMo-Guardrails docs
  • I have updated the package to the latest version before submitting this issue
  • (optional) I have used the develop branch
  • I have searched the existing issues of NeMo-Guardrails

Python version (python --version)

Python 3.13.2

Operating system/version

MacOS Tahoe 26.0.1

NeMo-Guardrails version (if you must use a specific version and not the latest

latest

Describe the bug

While reviewing #1383, several possible race and deadlock conditions were identified in the embeddings/basic.py file:

Steps To Reproduce

Identified statically from code analysis

Expected Behavior

Expect embeddings index not to hang or deadlock

Actual Behavior

Possible hang and/or deadlock when building index

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workingstatus: needs triageNew issues that have not yet been reviewed or categorized.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions