-
Notifications
You must be signed in to change notification settings - Fork 564
Open
Labels
bugSomething isn't workingSomething isn't workingstatus: needs triageNew issues that have not yet been reviewed or categorized.New issues that have not yet been reviewed or categorized.
Description
Did you check docs and existing issues?
- I have read all the NeMo-Guardrails docs
- I have updated the package to the latest version before submitting this issue
- (optional) I have used the develop branch
- I have searched the existing issues of NeMo-Guardrails
Python version (python --version)
Python 3.13.2
Operating system/version
MacOS Tahoe 26.0.1
NeMo-Guardrails version (if you must use a specific version and not the latest
latest
Describe the bug
While reviewing #1383, several possible race and deadlock conditions were identified in the embeddings/basic.py file:
- Indentation can cause deadlock.
- Missing lock on
self._current_batch_finished_eventcan cause hangs. - Initialization of events may create spurious RuntimeError
Steps To Reproduce
Identified statically from code analysis
Expected Behavior
Expect embeddings index not to hang or deadlock
Actual Behavior
Possible hang and/or deadlock when building index
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't workingstatus: needs triageNew issues that have not yet been reviewed or categorized.New issues that have not yet been reviewed or categorized.