Address Pouyan's feedback

Author: tgasser-nv

nemoguardrails/cli/__init__.py

@@ -225,9 +225,7 @@ def convert(
     absolute_path = os.path.abspath(path)
 
     # Typer CLI args have to use an enum, not literal. Convert to Literal here
-    from_version_literal: Literal["1.0", "2.0-alpha"] = (
-        "1.0" if from_version == ColangVersions.one else "2.0-alpha"
-    )
+    from_version_literal: Literal["1.0", "2.0-alpha"] = from_version.value
 
     migrate(
         path=absolute_path,

nemoguardrails/cli/chat.py

@@ -119,13 +119,13 @@ async def _run_chat_v1_0(
                 ] = await rails_app.generate_async(messages=history)
 
                 # Handle different return types from generate_async
-                if type(response) == Tuple[Dict, Dict]:
+                if isinstance(response, tuple) and len(response) == 2:
                     bot_message = (
                         response[0]
                         if response
                         else {"role": "assistant", "content": ""}
                     )
-                elif type(response) == GenerationResponse:
+                elif isinstance(response, GenerationResponse):
                     # GenerationResponse case
                     response_attr = getattr(response, "response", None)
                     if isinstance(response_attr, list) and len(response_attr) > 0:
@@ -135,7 +135,7 @@ async def _run_chat_v1_0(
                             "role": "assistant",
                             "content": str(response_attr),
                         }
-                elif type(response) == Dict:
+                elif isinstance(response, dict):
                     # Direct dict case
                     bot_message = response
                 else:

nemoguardrails/cli/debugger.py

@@ -181,8 +181,6 @@ def get_loop_info(flow_config: FlowConfig) -> str:
     if order_by_name:
         rows.sort(key=lambda x: x[0])
     else:
-        if not state:
-            raise RuntimeError("No state available")
         flow_configs: Dict[str, FlowConfig] = state.flow_configs
         rows.sort(key=lambda x: (-flow_configs[x[0]].loop_priority, x[0]))
 
@@ -257,7 +255,7 @@ def tree(
                         # Convert Spec to Spec object if it's a Dict
                         spec: Spec = (
                             head_element_spec_op.spec
-                            if type(head_element_spec_op.spec) == SpecOp
+                            if isinstance(head_element_spec_op.spec, Spec)
                             else Spec(**cast(Dict, head_element_spec_op.spec))
                         )