Skip to content

Commit 1fa022a

Browse files
added a module to upload a lego compliant version of the data to dataverse
1 parent 1d582d6 commit 1fa022a

File tree

9 files changed

+1859
-36
lines changed

9 files changed

+1859
-36
lines changed

notes/01_download_raw_data.ipynb

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@
6161
},
6262
{
6363
"cell_type": "code",
64-
"execution_count": 5,
64+
"execution_count": null,
6565
"metadata": {},
6666
"outputs": [],
6767
"source": [
@@ -71,6 +71,8 @@
7171
" )->bool:\n",
7272
" '''\n",
7373
" Check that the query is valid\n",
74+
" ###TODO Not a good idea to overwrite components of the query body because the user may believe something and the function may give somehting else back\n",
75+
" Better to just tell them something is wrong\n",
7476
" '''\n",
7577
"\n",
7678
" required_keys = ['product_type', 'variable', 'year', 'month', 'day', 'time', 'area', 'data_format', 'download_format']\n",
@@ -308,7 +310,8 @@
308310
"#| export\n",
309311
"@hydra.main(config_path=\"../../conf\", config_name=\"config\", version_base=None)\n",
310312
"def main(cfg: DictConfig) -> None:\n",
311-
" download_raw_era5(cfg=cfg)"
313+
" download_raw_era5(cfg=cfg)\n",
314+
" # better approach would be to have the function only use the specific arguments of the config\n"
312315
]
313316
},
314317
{

0 commit comments

Comments
 (0)