Some refactoring in the component

Updating the mock
Adding stub into system and request tests
Updating footer testing

Author: A-Wheeto

app/components/cms/footer_component.rb

@@ -30,7 +30,7 @@ def link_blocks
   private
 
   def data_models_by_type(type)
-    data.data_models.select { |model| model.is_a?(type) }
+    data.select { |model| model.is_a?(type) }
   end
 
   def find_text_field(index)

app/services/cms/providers/strapi/factories/model_factory.rb

@@ -160,7 +160,6 @@ def self.to_menu(strapi_data, _all_data)
           def self.to_footer(strapi_data, _all_data)
             {
               link_blocks: strapi_data.map do |link|
-                byebug
                 link[:link].map {
                   Models::DynamicComponents::ContentBlocks::LinkWithIcon.new(
                     link_text: _1[:linkText],
@@ -171,7 +170,7 @@ def self.to_footer(strapi_data, _all_data)
                       caption: _1[:icon][:data][:attributes][:caption],
                       default_size: :small,
                       formats: _1[:icon][:data][:attributes][:formats]
-                    ),
+                    )
                   )
                 }
               end

app/services/cms/providers/strapi/mocks/meta/footer_link_block.rb

@@ -4,11 +4,15 @@ module Strapi
       module Mocks
         module Singles
           class Footer < StrapiMock
-            attribute(:companyLogo) { Mocks::Images::Image.as_model }
-            attribute(:funderLogo) { Mocks::Images::Image.as_model }
+            attribute(:companyLogo) { {data: Mocks::Images::Image.generate_raw_data} }
+            attribute(:funderLogo) { {data: Mocks::Images::Image.generate_raw_data} }
             attribute(:companyLogoLink) { Faker::Internet.url }
             attribute(:funderLogoLink) { Faker::Internet.url }
-            attribute(:linkBlock) { Meta::FooterLinkBlock.generate_data }
+            attribute(:linkBlock) { Array.new(4) { FooterLinkBlock.generate_data } }
+          end
+
+          class FooterLinkBlock < StrapiMock
+            attribute(:link) { Array.new(4) { DynamicComponents::ContentBlocks::LinkWithIcon.generate_data } }
           end
         end
       end

app/services/cms/providers/strapi/mocks/singles/footer.rb

@@ -1,5 +1,5 @@
 <footer class="govuk-footer ncce-footer">
   <% if @cms_footer %>
-    <%= render Cms::FooterComponent.new(data: @cms_footer) %>
+    <%= render Cms::FooterComponent.new(data: @cms_footer.data_models) %>
   <% end %>
 </footer>

app/views/components/_footer.html.erb

@@ -0,0 +1,31 @@
+# frozen_string_literal: true
+
+require "rails_helper"
+
+RSpec.describe Cms::FooterComponent, type: :component do
+  before do
+    render_inline(described_class.new(data: [
+      Cms::Models::Data::TextField.new(value: Faker::Lorem.word),
+      Cms::Models::Data::TextField.new(value: Faker::Lorem.word),
+      Cms::Mocks::Images::Image.as_model,
+      Cms::Mocks::Images::Image.as_model,
+      Cms::Models::Meta::FooterLinkBlock.new(
+        link_blocks: Array.new(4) do
+          Array.new(5) { Cms::Mocks::DynamicComponents::ContentBlocks::LinkWithIcon.as_model }
+        end
+      )
+    ]))
+  end
+
+  it "renders the component" do
+    expect(page).to have_css(".cms-footer-component")
+  end
+
+  it "renders company and funder logo images" do
+    expect(page).to have_css("img", count: 2)
+  end
+
+  it "renders the link blocks" do
+    expect(page).to have_css(".cms-footer-component__link-block", count: 4)
+  end
+end

spec/components/cms/footer_component_spec.rb

@@ -100,10 +100,12 @@ def page
   config.before(:each, type: :system) do
     driven_by selenium_driver
     stub_strapi_header
+    stub_strapi_footer
   end
 
   config.before(:each, type: :request) do
     stub_strapi_header
+    stub_strapi_footer
   end
 
   config.after(:each, js: true, type: :system) do |_spec|

spec/rails_helper.rb

@@ -0,0 +1,8 @@
+require "rails_helper"
+
+RSpec.describe Cms::Providers::Strapi::Queries::FooterLinkBlock do
+  it_should_behave_like "a strapi graphql embed", {key: "footer",
+    required_fields: %w[
+      link
+    ]}
+end

spec/services/cms/providers/strapi/queries/footer_link_block_spec.rb

@@ -6,70 +6,8 @@
     assign(:cms_footer, Cms::Singles::Footer.get)
   end
 
-  it "has a contact link" do
-    expect(rendered).to have_link("Email", href: "mailto:info@teachcomputing.org")
-  end
-
-  it "has a courses link" do
-    expect(rendered).to have_link("Courses", href: "/courses")
-  end
-
-  it "has a resources link" do
-    expect(rendered).to have_link("Teaching resources", href: "/curriculum")
-  end
-
-  it "has a news link" do
-    expect(rendered).to have_link("News", href: cms_posts_path)
-  end
-
-  it "has a privacy link" do
-    expect(rendered).to have_link("Privacy", href: "/privacy")
-  end
-
-  it "has a terms and conditions link" do
-    expect(rendered).to have_link("Terms and Conditions", href: "/terms-conditions")
-  end
-  it "has an accessibility statement link" do
-    expect(rendered).to have_link("Accessibility", href: "/accessibility-statement")
-  end
-
-  it "has an about link" do
-    expect(rendered).to have_link("About us", href: "/about")
-  end
-
-  it "has a get involved link" do
-    expect(rendered).to have_link("Get involved", href: "/get-involved")
-  end
-
-  it "has a pedagogy link" do
-    expect(rendered).to have_link("Pedagogy", href: "/pedagogy")
-  end
-
-  it "has a ITE providers link" do
-    expect(rendered).to have_link("ITE providers", href: "/support-for-ite-providers")
-  end
-
-  it "has a LinkedIn link" do
-    expect(rendered).to have_link("LinkedIn", href: %r{linkedin.com/company/national-centre-for-computing-education})
-  end
-
-  it "has an X link" do
-    expect(rendered).to have_link("X", href: %r{twitter.com/WeAreComputing})
-  end
-
-  it "has a facebook link" do
-    expect(rendered).to have_link("Facebook", href: %r{facebook.com/WeAreComputing})
-  end
-
-  it "has a LinkedIn icon" do
-    expect(rendered).to have_xpath('//img[contains(@class, "ncce-link__icon--footer")][contains(@alt, "LinkedIn logo")]')
-  end
-
-  it "has an X icon" do
-    expect(rendered).to have_xpath('//img[contains(@class, "ncce-link__icon--footer")][contains(@alt, "X logo")]')
-  end
-
-  it "has a facebook icon" do
-    expect(rendered).to have_xpath('//img[contains(@class, "ncce-link__icon--footer")][contains(@alt, "Facebook logo")]')
+  it "renders the footer component" do
+    render
+    expect(rendered).to have_css(".cms-footer-component")
   end
 end