Adding support for activity list to show legacy activities that have achievements

Author: msquance-stem

app/components/community_activity_list_component.rb

@@ -6,13 +6,16 @@ def initialize(programme_activity_grouping:, community_achievements:, number_to_
     @class_name = class_name
     @button_class = button_class
 
-    activities_with_achievements = programme_activity_grouping.programme_activities.not_legacy.map do |programme_activity|
+    activities_with_achievements = programme_activity_grouping.programme_activities.map do |programme_activity|
       {
         programme_activity:,
         achievement: community_achievements&.find { _1.activity_id == programme_activity.activity_id }
       }
     end
 
+    # Remove legacy only if they have an achievement
+    activities_with_achievements.delete_if { _1[:achievement].nil? && _1[:programme_activity].legacy }
+
     complete, non_complete = activities_with_achievements.partition { _1[:achievement]&.in_state? :complete }
 
     if complete.size < programme_activity_grouping.required_for_completion

spec/components/community_activity_list_component_spec.rb

@@ -47,4 +47,26 @@
       expect(page).to have_css(".community-activity-list--show-hide")
     end
   end
+
+  context "with legacy activity" do
+    let(:activity) { create(:activity, title: "Legacy activity") }
+    let(:programme_activities) {
+      create_list(:programme_activity, 2, programme_activity_grouping:)
+      create(:programme_activity, programme_activity_grouping:, activity:, legacy: true)
+    }
+
+    context "without achievement" do
+      it "should not show legacy activity" do
+        expect(page).not_to have_text("Legacy activity")
+      end
+    end
+
+    context "with achievement" do
+      let(:community_achievements) { [create(:completed_achievement, activity: activity)] }
+
+      it "should show legacy activity" do
+        expect(page).to have_text("Legacy activity")
+      end
+    end
+  end
 end