Adding replaced by logic to the course card component (done in the mapping layer) and then updating tests

Author: msquance-stem

app/services/cms/dynamic_components/course_card.rb

@@ -8,13 +8,23 @@ def initialize(title:, banner_text:, course_code:, description:, image:)
         @banner_text = banner_text
         @description = description
         @image = image
-        @course = begin
-          Achiever::Course::Template.find_by_activity_code(course_code)
-        rescue ActiveRecord::RecordNotFound
-          nil
+
+        activity = Activity.find_by(stem_activity_code: course_code)
+        @course = if activity
+          if activity.replaced_by
+            get_achiever_course(activity.replaced_by)
+          elsif activity
+            get_achiever_course(activity)
+          end
         end
       end
 
+      def get_achiever_course(activity)
+        Achiever::Course::Template.find_by_activity_code(activity.stem_activity_code)
+      rescue ActiveRecord::RecordNotFound
+        nil
+      end
+
       def render
         Cms::CourseCardComponent.new(title:, banner_text:, course:, description:, image:)
       end

spec/services/cms/dynamic_components/course_card_section_spec.rb

@@ -1,7 +1,11 @@
 require "rails_helper"
 
 RSpec.describe Cms::DynamicComponents::CourseCard do
+  let!(:activity) { Activity.find_by(stem_activity_code: "CP228") || create(:activity, stem_activity_code: "CP228") }
+  let!(:new_activity) { Activity.find_by(stem_activity_code: "CP229") || create(:activity, stem_activity_code: "CP229") }
+  let!(:replaced_activity) { create(:activity, stem_activity_code: "RP228", replaced_by: new_activity) }
   let(:valid_course_card) { Cms::Mocks::DynamicComponents::CourseCard.generate_data(course_code: "CP228") }
+  let(:replaced_course_card) { Cms::Mocks::DynamicComponents::CourseCard.generate_data(course_code: "RP228") }
   let(:invalid_course_card) { Cms::Mocks::DynamicComponents::CourseCard.generate_data(course_code: "NV228") }
 
   before do
@@ -10,30 +14,57 @@
   end
 
   context "with valid activity" do
-    before do
-      @card_section = Cms::Providers::Strapi::Factories::ComponentFactory.process_component(Cms::Mocks::CourseCardSection.generate_raw_data(cards: [valid_course_card]))
-    end
+    let(:card_section) { Cms::Providers::Strapi::Factories::ComponentFactory.process_component(Cms::Mocks::CourseCardSection.generate_raw_data(cards: [valid_course_card])) }
+    let(:first_block) { card_section.cards_block.first }
 
     it "should render as Cms::CardWrapperComponent" do
-      expect(@card_section.render).to be_a(Cms::CardWrapperComponent)
+      expect(card_section.render).to be_a(Cms::CardWrapperComponent)
     end
 
     it "should render cards as Cms::DynamicsComponents::CourseCard" do
-      expect(@card_section.cards_block.first.render).to be_a(Cms::CourseCardComponent)
+      expect(first_block.render).to be_a(Cms::CourseCardComponent)
     end
 
     it "should return true for valid code" do
-      expect(@card_section.cards_block.first.render.render?).to be true
+      expect(first_block.render.render?).to be true
+    end
+
+    it "should have correct course instance" do
+      expect(first_block.course.activity_code).to eq("CP228")
     end
   end
 
   context "with invalid activity" do
-    before do
-      @card_section = Cms::Providers::Strapi::Factories::ComponentFactory.process_component(Cms::Mocks::CourseCardSection.generate_raw_data(cards: [invalid_course_card]))
-    end
+    let(:card_section) { Cms::Providers::Strapi::Factories::ComponentFactory.process_component(Cms::Mocks::CourseCardSection.generate_raw_data(cards: [invalid_course_card])) }
+    let(:first_block) { card_section.cards_block.first }
 
     it "should return false for invalid code" do
-      expect(@card_section.cards_block.first.render.render?).to be false
+      expect(first_block.render.render?).to be false
+    end
+
+    it "should have no course instance" do
+      expect(first_block.course).to be_nil
+    end
+  end
+
+  context "with replaced activity" do
+    let(:card_section) { Cms::Providers::Strapi::Factories::ComponentFactory.process_component(Cms::Mocks::CourseCardSection.generate_raw_data(cards: [replaced_course_card])) }
+    let(:first_block) { card_section.cards_block.first }
+
+    it "should render as Cms::CardWrapperComponent" do
+      expect(card_section.render).to be_a(Cms::CardWrapperComponent)
+    end
+
+    it "should render cards as Cms::DynamicsComponents::CourseCard" do
+      expect(first_block.render).to be_a(Cms::CourseCardComponent)
+    end
+
+    it "should return true for valid code" do
+      expect(first_block.render.render?).to be true
+    end
+
+    it "should have correct course instance" do
+      expect(first_block.course.activity_code).to eq("CP229")
     end
   end
 end