Skip to content

Commit a1d71a7

Browse files
committed
Adding additional testing and improving comment
1 parent c13a3c8 commit a1d71a7

File tree

2 files changed

+7
-1
lines changed

2 files changed

+7
-1
lines changed

app/components/community_activity_list_component.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ def initialize(programme_activity_grouping:, community_achievements:, number_to_
1313
}
1414
end
1515

16-
# Remove legacy only if they have an achievement
16+
# Remove legacy if they do not have an achievement
1717
activities_with_achievements.delete_if { _1[:achievement].nil? && _1[:programme_activity].legacy }
1818

1919
complete, non_complete = activities_with_achievements.partition { _1[:achievement]&.in_state? :complete }

spec/models/programme_activity_grouping_spec.rb

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -80,6 +80,12 @@
8080
end
8181
end
8282

83+
describe "#objective_displayed_in_body?" do
84+
it "should default to true" do
85+
expect(programme_activity_grouping.objective_displayed_in_body?).to be true
86+
end
87+
end
88+
8389
describe "#users_completed" do
8490
let!(:programme) { create(:programme) }
8591
let!(:programme_activity_grouping) { create(:programme_activity_grouping, required_for_completion: 3, programme:) }

0 commit comments

Comments
 (0)