Skip to content

Commit 7e2681a

Browse files
Merge pull request #2307 from NCCE/2970-feature-branch---april-1st-removals
Feature branch - April 1st 2025 contract changes Lots of changes but main highlights are Removal of Hubs and Clusters Changes to search to remove hubs, date and course type filters Copy changes to remove references to face to face or remote course, subsidies, funding, hubs, clusters Creation of new replaced by system, that handles redirecting to new courses (requires the old course to be turned off in Dynamics)
2 parents 161d6a3 + 4be1b89 commit 7e2681a

File tree

196 files changed

+789
-2687
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

196 files changed

+789
-2687
lines changed

Dockerfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
FROM ruby:3.3.6-alpine
22
RUN apk update
3-
RUN apk --no-cache add curl build-base postgresql-dev tzdata nodejs chromium chromium-chromedriver python3 python3-dev py3-pip yarn procps bash bash-completion sudo openssh docker git less graphviz yaml-dev
3+
RUN apk --no-cache add curl build-base postgresql-dev tzdata nodejs chromium chromium-chromedriver python3 python3-dev py3-pip yarn procps bash bash-completion sudo openssh docker git less graphviz yaml-dev libffi-dev
44
RUN pip install --upgrade pip --break-system-packages
55
RUN pip3 install -U selenium --break-system-packages
66
RUN curl https://cli-assets.heroku.com/install.sh | sh

Gemfile.lock

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -90,14 +90,14 @@ GEM
9090
kaminari (~> 1.2.2)
9191
sassc-rails (~> 2.1)
9292
selectize-rails (~> 0.6)
93-
administrate-field-active_storage (0.3.8)
93+
administrate-field-active_storage (1.0.5)
9494
administrate (>= 0.2.2)
95-
rails (>= 6.0)
95+
rails (>= 7.0)
9696
administrate-field-jsonb (0.4.6)
9797
administrate (< 1.0.0)
9898
rails (>= 4.2)
99-
administrate-field-nested_has_many (1.3.0)
100-
administrate (> 0.8, < 1)
99+
administrate-field-nested_has_many (2.1.0)
100+
administrate (>= 0.19, < 1)
101101
cocoon (~> 1.2, >= 1.2.11)
102102
ast (2.4.2)
103103
attr_encrypted (4.2.0)
@@ -260,7 +260,7 @@ GEM
260260
logger
261261
faraday-net_http (3.4.0)
262262
net-http (>= 0.5.0)
263-
ffi (1.15.5)
263+
ffi (1.17.1)
264264
fiber-storage (1.0.0)
265265
fog-aws (3.30.0)
266266
base64 (~> 0.2.0)
@@ -384,7 +384,7 @@ GEM
384384
rake
385385
mini_mime (1.1.5)
386386
mini_portile2 (2.8.8)
387-
minitest (5.25.4)
387+
minitest (5.25.5)
388388
msgpack (1.8.0)
389389
multi_json (1.15.0)
390390
multi_xml (0.6.0)
@@ -695,12 +695,12 @@ GEM
695695
lint_roller (~> 1.0)
696696
rubocop-rails (~> 2.20.2)
697697
statesman (10.0.0)
698-
stringio (3.1.3)
698+
stringio (3.1.5)
699699
terser (1.2.5)
700700
execjs (>= 0.3.0, < 3)
701701
thor (1.3.2)
702702
thread_safe (0.3.6)
703-
tilt (2.2.0)
703+
tilt (2.6.0)
704704
timecop (0.9.8)
705705
timeout (0.4.3)
706706
ttfunk (1.7.0)
@@ -751,7 +751,7 @@ GEM
751751
xpath (3.2.0)
752752
nokogiri (~> 1.8)
753753
yard (0.9.36)
754-
zeitwerk (2.7.1)
754+
zeitwerk (2.7.2)
755755

756756
PLATFORMS
757757
ruby

app/assets/config/manifest.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,5 +2,6 @@
22
//= link administrate/application.js
33
//= link administrate-field-nested_has_many/application.css
44
//= link administrate-field-nested_has_many/application.js
5+
//= link administrate-field-active_storage/application.css
56
//= link administrate-field-jsonb/application.css
67
//= link administrate-field-jsonb/application.js

app/components/bursary_component.rb

Lines changed: 0 additions & 34 deletions
This file was deleted.

app/components/bursary_component/bursary_component.html.erb

Lines changed: 0 additions & 16 deletions
This file was deleted.

app/components/bursary_component/bursary_component.scss

Lines changed: 0 additions & 21 deletions
This file was deleted.

app/components/bursary_component/bursary_component.yml

Lines changed: 0 additions & 3 deletions
This file was deleted.

app/components/cms/card_wrapper_component/card_wrapper_component.html.erb

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,9 +8,11 @@
88
<% end %>
99
<div class="cms-card-wrapper__grid" style="<%= cards_per_row %>">
1010
<% @cards_block.each do |card| %>
11-
<div class="cms-card-wrapper__card">
12-
<%= render card.render %>
13-
</div>
11+
<% if card.render.render? %>
12+
<div class="cms-card-wrapper__card">
13+
<%= render card.render %>
14+
</div>
15+
<% end %>
1416
<% end %>
1517
</div>
1618
<% end %>

app/components/cms/course_card_component.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,9 +6,9 @@ class Cms::CourseCardComponent < ViewComponent::Base
66
to: :helpers
77

88
def initialize(title:, banner_text:, course:, description:, image:)
9-
@title = title
109
@banner_text = banner_text
1110
@course = course
11+
@title = title.presence || @course&.title
1212
@description = description
1313
@image = image
1414
end

app/components/cms/course_card_component/course_card_component.html.erb

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,9 +11,9 @@
1111

1212
<%= link_to @title, course_path(id: @course.activity_code, name: @course.title.parameterize), class: 'govuk-!-font-weight-bold govuk-body ncce-link' %>
1313
<div class="courses-cms-card__details">
14-
<p class="govuk-body">
15-
<%= render @description.render %>
16-
</p>
14+
<div class="courses-cms-card__details-content">
15+
<%= render @description.render if @description %>
16+
</div>
1717
<div class="courses-cms-card__icons">
1818
<div>
1919
<span class="govuk-body-s <%= course_meta_icon_class(@course) %> courses-cms-card__type">

0 commit comments

Comments
 (0)