Fixing more issues with featured images and adding extra testing

Author: msquance-stem

app/services/cms/providers/strapi/factories/model_factory.rb

@@ -68,7 +68,7 @@ def self.to_blog_preview(strapi_data, _all_data)
               title: strapi_data[:title],
               excerpt: strapi_data[:excerpt],
               publish_date: strapi_data[:publishDate],
-              featured_image: strapi_data[:featuredImage][:data].nil? ? nil : Models::Images::FeaturedImage.new(**to_featured_image(strapi_data[:featuredImage][:data][:attributes], nil, :small)),
+              featured_image: strapi_data[:featuredImage][:data].nil? ? nil : Models::Images::FeaturedImage.new(**to_featured_image(strapi_data[:featuredImage], nil, :small)),
               slug: strapi_data[:slug]
             }
           end
@@ -119,7 +119,7 @@ def self.to_enrichment(strapi_data)
           end
 
           def self.to_featured_image(strapi_data, _all_data, size = :large)
-            return nil unless strapi_data[:data][:attributes]
+            return nil unless strapi_data.dig(:data, :attributes)
             image_data = strapi_data[:data][:attributes]
             {
               url: image_data[:url],

app/services/cms/providers/strapi/mocks/collections/blog_preview.rb

@@ -0,0 +1,17 @@
+module Cms
+  module Providers
+    module Strapi
+      module Mocks
+        module Collections
+          class BlogPreview < StrapiMock
+            attribute(:slug) { Faker::Internet.slug }
+            attribute(:publishDate) { Faker::Date.backward.to_s }
+            attribute(:excerpt) { Faker::Lorem.paragraph }
+            attribute(:title) { Faker::Lorem.sentence }
+            attribute(:featuredImage) { {data: Images::Image.generate_raw_data} }
+          end
+        end
+      end
+    end
+  end
+end

spec/services/cms/models/collections/blog_preview_spec.rb

@@ -0,0 +1,11 @@
+require "rails_helper"
+
+RSpec.describe Cms::Models::Collections::BlogPreview do
+  it "should render a BlogPreviewComponent" do
+    @comp = Cms::Providers::Strapi::Factories::ModelFactory.process_model(
+      {model: Cms::Models::Collections::BlogPreview, key: nil},
+      Cms::Mocks::Collections::BlogPreview.generate_data
+    )
+    expect(@comp.render).to be_instance_of(BlogPreviewComponent)
+  end
+end

spec/services/cms/models/dynamic_components/content_blocks/course_card_section_spec.rb

@@ -0,0 +1,104 @@
+require "rails_helper"
+
+RSpec.describe Cms::Models::DynamicComponents::ContentBlocks::CourseCard do
+  let!(:activity) { Activity.find_by(stem_activity_code: "CP228") || create(:activity, stem_activity_code: "CP228") }
+  let!(:new_activity) { Activity.find_by(stem_activity_code: "CP229") || create(:activity, stem_activity_code: "CP229") }
+  let!(:replaced_activity) { create(:activity, stem_activity_code: "RP228", replaced_by: new_activity) }
+  let(:valid_course_card) { Cms::Mocks::DynamicComponents::ContentBlocks::CourseCard.generate_data(course_code: "CP228") }
+  let(:replaced_course_card) { Cms::Mocks::DynamicComponents::ContentBlocks::CourseCard.generate_data(course_code: "RP228") }
+  let(:invalid_course_card) { Cms::Mocks::DynamicComponents::ContentBlocks::CourseCard.generate_data(course_code: "NV228") }
+
+  context "with achiever match" do
+    before do
+      stub_course_templates
+      stub_duration_units
+      allow(Sentry).to receive(:capture_message)
+    end
+
+    context "with valid activity" do
+      let(:card_section) { Cms::Providers::Strapi::Factories::ComponentFactory.process_component(Cms::Mocks::DynamicComponents::Blocks::CourseCardSection.generate_raw_data(cards: [valid_course_card])) }
+      let(:first_block) { card_section.cards_block.first }
+
+      it "should render as Cms::CardWrapperComponent" do
+        expect(card_section.render).to be_a(Cms::CardWrapperComponent)
+      end
+
+      it "should render cards as Cms::DynamicsComponents::CourseCard" do
+        expect(first_block.render).to be_a(Cms::CourseCardComponent)
+      end
+
+      it "should return true for valid code" do
+        expect(first_block.render.render?).to be true
+      end
+
+      it "should have correct course instance" do
+        expect(first_block.course.activity_code).to eq("CP228")
+      end
+
+      it "should not send sentry notification" do
+        expect(Sentry).not_to have_received(:capture_message)
+      end
+    end
+
+    context "with invalid activity" do
+      let(:card_section) { Cms::Providers::Strapi::Factories::ComponentFactory.process_component(Cms::Mocks::DynamicComponents::Blocks::CourseCardSection.generate_raw_data(cards: [invalid_course_card])) }
+      let(:first_block) { card_section.cards_block.first }
+
+      it "should return false for invalid code" do
+        expect(first_block.render.render?).to be false
+      end
+
+      it "should have no course instance" do
+        expect(first_block.course).to be_nil
+      end
+
+      it "should not send sentry notification" do
+        expect(Sentry).not_to have_received(:capture_message)
+      end
+    end
+
+    context "with replaced activity" do
+      let!(:card_section) { Cms::Providers::Strapi::Factories::ComponentFactory.process_component(Cms::Mocks::DynamicComponents::Blocks::CourseCardSection.generate_raw_data(cards: [replaced_course_card])) }
+      let(:first_block) { card_section.cards_block.first }
+
+      it "should render as Cms::CardWrapperComponent" do
+        expect(card_section.render).to be_a(Cms::CardWrapperComponent)
+      end
+
+      it "should render cards as Cms::DynamicsComponents::CourseCard" do
+        expect(first_block.render).to be_a(Cms::CourseCardComponent)
+      end
+
+      it "should return true for valid code" do
+        expect(first_block.render.render?).to be true
+      end
+
+      it "should have correct course instance" do
+        expect(first_block.course.activity_code).to eq("CP229")
+      end
+
+      it "should send sentry notification" do
+        expect(Sentry).to have_received(:capture_message).once.with("Course card has been found with a now replaced course (RP228 -> CP229) - get comms to update Strapi to new course instance")
+      end
+    end
+  end
+
+  context "without achiever" do
+    before do
+      stub_failed_course_templates
+    end
+
+    context "with valid activity" do
+      let(:card_section) { Cms::Providers::Strapi::Factories::ComponentFactory.process_component(Cms::Mocks::DynamicComponents::Blocks::CourseCardSection.generate_raw_data(cards: [valid_course_card])) }
+      let(:first_block) { card_section.cards_block.first }
+
+      it "should render as Cms::CardWrapperComponent" do
+        expect(card_section.render).to be_a(Cms::CardWrapperComponent)
+      end
+
+      it "should set course to nil" do
+        expect(first_block.course).to be nil
+      end
+    end
+  end
+end

spec/services/cms/models/dynamic_components/content_blocks/course_card_spec.rb

@@ -0,0 +1,13 @@
+require "rails_helper"
+
+RSpec.describe Cms::Models::DynamicComponents::ContentBlocks::FileLink do
+  before do
+    @link = Cms::Providers::Strapi::Factories::ComponentFactory.process_component(
+      Cms::Mocks::DynamicComponents::ContentBlocks::FileLink.generate_raw_data
+    )
+  end
+
+  it "should render as Cms::FileLinkComponent" do
+    expect(@link.render).to be_a(Cms::FileComponent)
+  end
+end

spec/services/cms/models/dynamic_components/content_blocks/file_link_spec.rb

@@ -1,7 +1,7 @@
 require "rails_helper"
 
 RSpec.describe Cms::Models::Images::FeaturedImage do
-  it "should render a Cms::ImageComponent" do
+  it "should render a FeaturedImageComponent" do
     @comp = Cms::Providers::Strapi::Factories::ModelFactory.process_model(
       {model: Cms::Models::Images::FeaturedImage, key: :featuredImage},
       {featuredImage: {data: Cms::Mocks::Images::Image.generate_raw_data}}

spec/services/cms/models/images/featured_image_spec.rb

@@ -19,6 +19,16 @@ def stub_age_groups
       "https://stemraspberrypiapi.dev3.smartmembership.net/smartconnector.smartconnector.svc/JSON/Get?Page=1&RecordCount=1000&cmd=OptionsetAgeGroups").to_return(body: json_response)
   end
 
+  def stub_failed_course_templates
+    json_response = File.read("spec/support/achiever/failure.json")
+    stub_request(:get,
+      "https://stemraspberrypiapi.dev3.smartmembership.net/smartconnector.smartconnector.svc/JSON/Get?HideFromweb=0&Page=1&ProgrammeName=ncce&RecordCount=1000&cmd=CourseTemplatesListingByProgramme").to_return(body: json_response)
+    stub_request(:get,
+      "https://stemraspberrypiapi.dev3.smartmembership.net/smartconnector.smartconnector.svc/JSON/Get?HideFromweb=0&Page=1&ProgrammeName=PDLP&RecordCount=1000&cmd=CourseTemplatesListingByProgramme").to_return(body: json_response)
+    stub_request(:get,
+      "https://stemraspberrypiapi.dev3.smartmembership.net/smartconnector.smartconnector.svc/JSON/Get?HideFromweb=0&Page=1&ProgrammeName=Computing%20Clusters&RecordCount=1000&cmd=CourseTemplatesListingByProgramme").to_return(body: json_response)
+  end
+
   def stub_course_templates
     json_response = File.new("spec/support/achiever/courses/templates.json")
     stub_request(:get,