Changing the logic so legacy courses still count towards programme activity completion

Author: msquance-stem

app/models/programme_activity_grouping.rb

@@ -55,7 +55,6 @@ def users_completed(users:)
       .belonging_to_programme(programme)
       .joins(activity: :programme_activities)
       .where(
-        activities: {programme_activities: {legacy: false}},
         user: users
       )
       .group_by(&:user_id)

spec/models/programme_activity_grouping_spec.rb

@@ -55,9 +55,9 @@
         programme_activity.update(legacy: true)
       end
 
-      it "returns false" do
+      it "returns true" do
         grouping = programme_activity_groupings.first
-        expect(grouping.user_complete?(user)).to be false
+        expect(grouping.user_complete?(user)).to be true
       end
     end
   end