Skip to content

Commit 48a4fa7

Browse files
committed
Moving page title query to a more appropriate location and updating base query to reflect the change
Fixing sonarcloud issues in the scss
1 parent 23bf4c5 commit 48a4fa7

File tree

4 files changed

+4
-28
lines changed

4 files changed

+4
-28
lines changed

app/components/cms/course_card_component/course_card_component.scss

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -50,8 +50,7 @@
5050
display: inline-block;
5151
margin-bottom: 0;
5252
background-size: 16px 16px;
53-
display: inline-block;
54-
margin-bottom: 0;
53+
5554
@include govuk-media-query($from: tablet) {
5655
background-size: 20px 20px;
5756
}
@@ -61,6 +60,7 @@
6160
display: inline-block;
6261
margin-bottom: 0;
6362
background-size: 16px 16px;
63+
6464
@include govuk-media-query($from: tablet) {
6565
background-size: 20px 20px;
6666
}

app/services/cms/providers/strapi/queries/base_query.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ class BaseQuery
1212
Models::EnrichmentDynamicZone => EnrichmentDynamicZone,
1313
Models::EnrichmentList => EnrichmentList,
1414
Models::FeaturedImage => FeaturedImage,
15-
Models::PageTitle => Components::Blocks::PageTitle,
15+
Models::PageTitle => PageTitle,
1616
Models::Seo => Seo,
1717
Models::SimpleTitle => SimpleField,
1818
Models::Slug => Slug,

app/services/cms/providers/strapi/queries/components/blocks/page_title.rb

Lines changed: 0 additions & 24 deletions
This file was deleted.

app/services/cms/providers/strapi/queries/page_title.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ module Providers
33
module Strapi
44
module Queries
55
class PageTitle
6-
def self.fields(name)
6+
def self.embed(name)
77
<<~GRAPHQL.freeze
88
#{name} {
99
title

0 commit comments

Comments
 (0)