Skip to content
This repository was archived by the owner on Jan 15, 2024. It is now read-only.

Commit 8dec88a

Browse files
author
steven.roulleau
committed
fix(Editor): add touchmove hack to be compatible with Scribble
MSIS-2654
1 parent 96fb6c0 commit 8dec88a

File tree

2 files changed

+5
-1
lines changed

2 files changed

+5
-1
lines changed

src/grabber/PointerEventGrabber.js

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -49,6 +49,7 @@ function extractPoint (event, domElement, configuration, offsetTop = 0, offsetLe
4949
}
5050
}
5151

52+
const prevent = (e) => e.preventDefault()
5253
/**
5354
* Listen for the desired events
5455
* @param {Element} element DOM element to attach events listeners
@@ -191,6 +192,8 @@ export function attach (element, editor, offsetTop = 0, offsetLeft = 0) {
191192
item.types.forEach(type => element.addEventListener(type, item.listener, context.options))
192193
})
193194

195+
element.addEventListener('touchmove', prevent)
196+
194197
// FIXME investigate why this is needed for iOS devices
195198
document.documentElement.addEventListener('pointerdown', () => {})
196199
return context
@@ -201,5 +204,6 @@ export function detach (element, context) {
201204
context.listeners.forEach((item) => {
202205
item.types.forEach(type => element.removeEventListener(type, item.listener, context.options))
203206
})
207+
element.removeEventListener('touchmove', prevent)
204208
document.documentElement.removeEventListener('pointerdown', () => {})
205209
}

test/mocha/partial/02-behaviors/PointerEventGrabber.spec.babel.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ describe('Testing the Grabber', () => {
1919
logger.debug('Attaching document to spied element')
2020
grabber.attach(spiedDomDocument, spiedEditor)
2121

22-
assert.strictEqual(spiedDomDocument.addEventListener.callCount, 6, 'Not all events have been registered')
22+
assert.strictEqual(spiedDomDocument.addEventListener.callCount, 7, 'Not all events have been registered')
2323
})
2424

2525
// TODO Add some tests sending events and checking that grabber behave as expected

0 commit comments

Comments
 (0)