Skip to content
This repository was archived by the owner on Jan 15, 2024. It is now read-only.

Commit 7053e46

Browse files
author
steven.roulleau
committed
fix(reco): last export not taken
MSIS-2618
1 parent 70a1695 commit 7053e46

File tree

2 files changed

+14
-22
lines changed

2 files changed

+14
-22
lines changed

src/recognizer/websocket/WsBuilder.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -110,17 +110,17 @@ export function buildWebSocketCallback (recognizerContext) {
110110
recognitionContext.contentChange.resolve([undefined, message.data])
111111
break
112112
case 'exported':
113-
recognitionContext.response.resolve([undefined, message.data])
113+
recognitionContext.response(undefined, message.data)
114114
break
115115
case 'svgPatch':
116116
recognitionContext.patch(undefined, message.data)
117117
break
118118
case 'supportedImportMimeTypes':
119119
recognizerContextRef.supportedImportMimeTypes = message.data.mimeTypes
120-
recognitionContext.response.resolve([undefined, message.data])
120+
recognitionContext.response(undefined, message.data)
121121
break
122122
case 'fileChunkAck':
123-
recognitionContext.response.resolve([undefined, message.data])
123+
recognitionContext.response(undefined, message.data)
124124
break
125125
case 'idle':
126126
recognizerContextRef.idle = true

src/recognizer/websocket/iinkWsRecognizer.js

Lines changed: 11 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -348,11 +348,15 @@ export async function init (recognizerContext, model) {
348348
// eslint-disable-next-line no-underscore-dangle
349349
async function _prepareMessage (recognizerContext, model, buildFunction, ...params) {
350350
logger.info(`-- Prepare message for ${buildFunction.name} --`)
351-
const response = PromiseHelper.destructurePromise()
352351
const contentChange = PromiseHelper.destructurePromise()
353352
const recognizerContextRef = RecognizerContext.setRecognitionContext(recognizerContext, {
354353
model,
355-
response,
354+
response: (err, res) => {
355+
const onDemand = recognizerContext.editor.configuration.triggers.exportContent === Constants.Trigger.DEMAND
356+
if (!onDemand || (onDemand && buildFunction.name === 'buildExport')) {
357+
responseCallback(model, err, res, recognizerContextRef)
358+
}
359+
},
356360
contentChange,
357361
patch: (err, res) => responseCallback(model, err, res, recognizerContextRef),
358362
error: (err, res) => responseCallback(model, err, res, recognizerContextRef)
@@ -363,15 +367,6 @@ async function _prepareMessage (recognizerContext, model, buildFunction, ...para
363367
WsRecognizerUtil.retry(_prepareMessage, recognizerContext, model, buildFunction, ...params)
364368
})
365369

366-
const onDemand = recognizerContext.editor.configuration.triggers.exportContent === Constants.Trigger.DEMAND
367-
if (!onDemand || (onDemand && buildFunction.name === 'buildExport')) {
368-
const resp = await recognizerContextRef.recognitionContexts[0].response.promise
369-
370-
if (resp) {
371-
responseCallback(model, resp[0], resp[1], recognizerContextRef)
372-
}
373-
}
374-
375370
const contentChanged = await recognizerContextRef.recognitionContexts[0].contentChange.promise
376371

377372
if (contentChanged) {
@@ -457,11 +452,14 @@ export function redo (recognizerContext, model) {
457452
* @param {Model} model Current model
458453
*/
459454
export async function clear (recognizerContext, model) {
460-
const response = PromiseHelper.destructurePromise()
461455
const contentChange = PromiseHelper.destructurePromise()
462456
const recognizerContextRef = RecognizerContext.setRecognitionContext(recognizerContext, {
463457
model,
464-
response,
458+
response: (err, res) => {
459+
if (recognizerContext.editor.configuration.triggers.exportContent !== Constants.Trigger.DEMAND) {
460+
responseCallback(model, err, res, recognizerContextRef)
461+
}
462+
},
465463
contentChange,
466464
// eslint-disable-next-line handle-callback-err
467465
patch: async (error, result) => {
@@ -472,12 +470,6 @@ export async function clear (recognizerContext, model) {
472470
WsRecognizerUtil.sendMessage(recognizerContextRef, buildClear)
473471
.catch(exception => WsRecognizerUtil.retry(clear, recognizerContext, model))
474472

475-
if (recognizerContext.editor.configuration.triggers.exportContent !== Constants.Trigger.DEMAND) {
476-
const resp = await recognizerContextRef.recognitionContexts[0].response.promise
477-
if (resp) {
478-
responseCallback(model, resp[0], resp[1], recognizerContextRef)
479-
}
480-
}
481473
const contentChanged = await recognizerContextRef.recognitionContexts[0].contentChange.promise
482474

483475
if (contentChanged) {

0 commit comments

Comments
 (0)