Skip to content

Commit 1306a16

Browse files
committed
Add a requirement on iconv and suggest mbstring in composer.json
The iconv PHP extension is used in `ParserState` and hence needs to be required. The mbstring extension is optional, but helpful. So we should help users discover this with a `suggest` entry in the `composer.json`.
1 parent ddf0daa commit 1306a16

File tree

1 file changed

+5
-1
lines changed

1 file changed

+5
-1
lines changed

composer.json

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,12 +15,16 @@
1515
}
1616
],
1717
"require": {
18-
"php": ">=5.6.20"
18+
"php": ">=5.6.20",
19+
"ext-iconv": "*"
1920
},
2021
"require-dev": {
2122
"phpunit/phpunit": "^4.8.36",
2223
"codacy/coverage": "^1.4"
2324
},
25+
"suggest": {
26+
"ext-mbstring": "for parsing UTF-8 CSS"
27+
},
2428
"autoload": {
2529
"psr-4": {
2630
"Sabberworm\\CSS\\": "src/"

0 commit comments

Comments
 (0)