Ensure the CUDA radix sort backend synchronizes before returning; otherwise,

brycelelbach · brycelelbach · commit 0e2cb9782cee · 2020-09-15T14:12:21.000-07:00
copies from temporary storage will race with destruction of said temporary
storage.

NVC++ FS #28463

Reviewed-By: David Olsen &lt;dolsen@nvidia.com&gt;
diff --git a/thrust/system/cuda/detail/sort.h b/thrust/system/cuda/detail/sort.h
@@ -1598,6 +1598,10 @@ namespace __smart_sort {
     {
       cuda_cub::copy(policy, keys.begin(), keys.end(), keys_first);
     }
+
+    cuda_cub::throw_on_error(
+      cuda_cub::synchronize(policy),
+      "merge_sort: failed to synchronize");
   }
 }    // namespace __smart_sort
 

Original file line number	Diff line number	Diff line change
`@@ -1598,6 +1598,10 @@ namespace __smart_sort {`
`1598`	`1598`	`{`
`1599`	`1599`	`cuda_cub::copy(policy, keys.begin(), keys.end(), keys_first);`
`1600`	`1600`	`}`
	`1601`	`+`
	`1602`	`+ cuda_cub::throw_on_error(`
	`1603`	`+ cuda_cub::synchronize(policy),`
	`1604`	`+ "merge_sort: failed to synchronize");`
`1601`	`1605`	`}`
`1602`	`1606`	`} // namespace __smart_sort`
`1603`	`1607`