fix: duplication tags temp

Author: MuYunyun

packages/crd-scripts/src/conf/getPrerenderRoutes.js

@@ -1,4 +1,7 @@
-const DirectoryTree = require('./node-directory-tree')
+const {
+  directoryTree,
+  mapTagsWithArticle
+} = require('./node-directory-tree')
 
 const getDirTree = (cmd) => {
   const dir = cmd.markdownPaths
@@ -8,13 +11,12 @@ const getDirTree = (cmd) => {
     extensions: /\.md/,
     prerender: true,
   }
-  const mapTagsWithArticle = []
-  const dirTree = dirs.map(path => DirectoryTree({
+  console.log('mapTagsWithArticle before', mapTagsWithArticle)
+  const dirTree = dirs.map(path => directoryTree({
     path,
     options: otherProps,
-    mapTagsWithArticle
   }))
-
+  console.log('mapTagsWithArticle after', mapTagsWithArticle)
   return {
     dirTree,
     // map tags with path. [{ tagName: 'custom Tag 1', mapArticle: [{ path, name }]}]

packages/crd-scripts/src/conf/node-directory-tree.js

@@ -41,6 +41,18 @@ function safeReadDirSync(path) {
   return dirData
 }
 
+// collect unique tags from all articles.
+const tagsArr = []
+
+// The global arr cache has side effects, to follow up optimizing.
+// [{
+//  tagName: 'customTag1',    // tag type name
+//  mapArticle: [{
+//    path,                   // click tag to jump route such as /tags/customTag1
+//    title                   // the name of article
+//  }]
+// }]
+const mapTagsWithArticle = []
 /** build directory Tree, fork from https://github.com/mihneadb/node-directory-tree
  * path: path for file
  * options: {
@@ -50,19 +62,10 @@ function safeReadDirSync(path) {
  *   prerender: Boolean. Used for prerender.
  *   generate: Boolean. Used for generating info in front-matter.
  * }
- * tagsArr: collect unique tags from all articles.
- * mapTagsWithArticle: [{
- *  tagName: 'customTag1',    // tag type name
- *  mapArticle: [{
- *    path,                   // click tag to jump route such as /tags/customTag1
- *    title                   // the name of article
- *  }]}]
  */
 function directoryTree({
   path,
   options,
-  tagsArr = [],
-  mapTagsWithArticle = [],
   routePath = ''
 }) {
   const name = PATH.basename(path, '.md')
@@ -132,6 +135,8 @@ function directoryTree({
                 title: name
               }]
             })
+
+            console.log('mapTagsWithArticle222', mapTagsWithArticle)
           }
         }
       }
@@ -171,8 +176,6 @@ function directoryTree({
         directoryTree({
           path: PATH.join(path, child),
           options,
-          tagsArr,
-          mapTagsWithArticle,
           routePath: routePropsCurrent
         }),
       )
@@ -187,4 +190,7 @@ function directoryTree({
   return item
 }
 
-module.exports = directoryTree
+module.exports = {
+  directoryTree,
+  mapTagsWithArticle
+}

packages/crd-scripts/src/conf/rawTreeReplaceLoader.js

@@ -1,5 +1,5 @@
 // A variation of https://github.com/react-doc/node-directory-tree-md/blob/master/lib/directory-tree-md.js
-const DirectoryTree = require('./node-directory-tree')
+const { directoryTree } = require('./node-directory-tree')
 const PATH = require('path')
 const { ifInGitIgnore } = require('../utils/index')
 
@@ -58,7 +58,7 @@ module.exports = function (source) {
   // if (this.cacheable) this.cacheable()
   if (directoryTrees && (!include || include.test(this.resourcePath))) {
     const dirs = Array.isArray(dir) ? dir : [dir]
-    const dirTree = dirs.map(path => DirectoryTree({
+    const dirTree = dirs.map(path => directoryTree({
       path,
       options: otherProps,
     }))

packages/crd-scripts/src/generate.js

@@ -1,6 +1,6 @@
 const fs = require('fs')
 const { docsConfig } = require('crd-utils')
-const DirectoryTree = require('./conf/node-directory-tree')
+const { directoryTree } = require('./conf/node-directory-tree')
 
 module.exports = function generate(program) {
   if (!fs.existsSync(docsConfig)) {
@@ -15,7 +15,7 @@ module.exports = function generate(program) {
     extensions: /\.md/,
     generate: true
   }
-  dirs.map(path => DirectoryTree({
+  dirs.map(path => directoryTree({
     path,
     options: otherProps,
   }))

packages/crd-scripts/src/utils/initCache.js

@@ -1,11 +1,11 @@
 const write = require('write')
 const path = require('path')
 const { cacheDirPath, getDocsConfig } = require('crd-utils')
-const DirectoryTree = require('../conf/node-directory-tree')
+const { directoryTree } = require('../conf/node-directory-tree')
 
 module.exports = function (program, cb) {
   const treeData = program.markdownPaths.map((markdownPath) => {
-    return DirectoryTree({
+    return directoryTree({
       path: markdownPath,
       options: {
         mdconf: true, // Markdown config for exsiting file.

packages/crd-seed/component/Tags/index.js

@@ -12,6 +12,7 @@ const Tags = () => {
   const routeMatch = useMatch(path) || {}
   const { name } = routeMatch.params || {}
 
+  console.log('mapTagsWithArticle', mapTagsWithArticle)
   return (
     <div className={styles.tags}>
       <div className={styles['tags-title']}>{name || 'Tags'}</div>