Skip to content

Commit 8b3190e

Browse files
committed
chore: code review upgrade react-router-dom to v6
1 parent ff6e869 commit 8b3190e

File tree

2 files changed

+14
-19
lines changed

2 files changed

+14
-19
lines changed

packages/crd-scripts/src/web/index.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import { hydrate, render } from 'react-dom'
1+
import { hydrate } from 'react-dom'
22
import { renderToString } from 'react-dom/server';
33
// import { hydrateRoot } from 'react-dom/client'
44
import '@babel/polyfill'
@@ -7,8 +7,8 @@ import RouterRoot from './Router'
77

88
if (ifDev) {
99
// dev render
10-
// document.getElementById('root').innerHTML = renderToString(<RouterRoot />)
11-
render(
10+
document.getElementById('root').innerHTML = renderToString(<RouterRoot />)
11+
hydrate(
1212
<RouterRoot />,
1313
document.getElementById('root'),
1414
)

packages/crd-seed/component/NoMatch/index.js

Lines changed: 11 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -1,25 +1,20 @@
1-
import { Outlet } from 'react-router-dom'
21
import styles from './index.less'
32

43
const NoMatch = () => {
5-
console.log('test 404')
64
// eslint-disable-next-line no-undef
75
const { user, repo } = DOCSCONFIG || {}
86
return (
9-
<>
10-
<table className={styles.noMatch}>
11-
<tbody>
12-
<tr>
13-
<td>
14-
<h1>404</h1>
15-
<div>你似乎来到了没有知识存在的荒原...</div>
16-
<section>在 github 访问<a href={`https://github.com/${user}/${repo}`}>该项目</a></section>
17-
</td>
18-
</tr>
19-
</tbody>
20-
</table>
21-
<Outlet />
22-
</>
7+
<table className={styles.noMatch}>
8+
<tbody>
9+
<tr>
10+
<td>
11+
<h1>404</h1>
12+
<div>你似乎来到了没有知识存在的荒原...</div>
13+
<section>在 github 访问<a href={`https://github.com/${user}/${repo}`}>该项目</a></section>
14+
</td>
15+
</tr>
16+
</tbody>
17+
</table>
2318
)
2419
}
2520

0 commit comments

Comments
 (0)