Skip to content

Commit d6f1946

Browse files
authored
Merge pull request #2592 from bagerard/minor_adjustment_w_latest_merge
Minor improvements related with recent merge for queryset_class
2 parents e099e3b + dee8d47 commit d6f1946

File tree

3 files changed

+4
-6
lines changed

3 files changed

+4
-6
lines changed

docs/changelog.rst

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@ Development
88
===========
99
- (Fill this out as you fix issues and develop your features).
1010
- EnumField improvements: now `choices` limits the values of an enum to allow
11+
- Fix bug that prevented instance queryset from using custom queryset_class #2589
1112
- Fix deepcopy of EmbeddedDocument #2202
1213
- Fix error when using precision=0 with DecimalField #2535
1314
- Add support for regex and whole word text search query #2568

mongoengine/document.py

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -583,11 +583,8 @@ def cascade_save(self, **kwargs):
583583
def _qs(self):
584584
"""Return the default queryset corresponding to this document."""
585585
if not hasattr(self, "__objects"):
586-
queryset_class = self._meta.get("queryset_class")
587-
if queryset_class is not None:
588-
self.__objects = queryset_class(self.__class__, self._get_collection())
589-
else:
590-
self.__objects = QuerySet(self.__class__, self._get_collection())
586+
queryset_class = self._meta.get("queryset_class", QuerySet)
587+
self.__objects = queryset_class(self.__class__, self._get_collection())
591588
return self.__objects
592589

593590
@property

tests/queryset/test_queryset.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3931,7 +3931,7 @@ class Post(Document):
39313931
Post.drop_collection()
39323932

39333933
assert isinstance(Post.objects, CustomQuerySet)
3934-
assert not Post.objects.delete()
3934+
assert Post.objects.delete() == 0
39353935

39363936
post = Post()
39373937
post.save()

0 commit comments

Comments
 (0)