General QOF improvements (#98)

* QOF improvements

* Fix lint, add cleaning

Author: michaeltintiuc

README.md

@@ -41,7 +41,7 @@ Apart from minor improvements and further testing of various mixes of Ionic comp
 | MS Edge Fix | :heavy_check_mark: | :heavy_check_mark: | Fully implemented |
 | Router keep-alive | :heavy_check_mark: | [Pending](https://github.com/ionic-team/ionic/pull/18561) | - |
 | Functional Inputs | :heavy_check_mark: | [Pending](https://github.com/ionic-team/ionic/pull/19087) | - |
-| Import controllers directly | :soon: | :x: | Improve treeshaking and sync with react and angular implementations |
+| Import controllers directly | :heavy_check_mark: | [Pending](https://github.com/ionic-team/ionic/pull/19573) | Improve treeshaking and sync with react and angular implementations |
 | Unit tests  | :x: | :x: |  Outdated as were originally written in plain JS, need to be updated for TS |
 
 ## Installing / Getting started
@@ -92,13 +92,16 @@ IonicVueRouter requires `ion-vue-router` element in order to render Ionic transi
 
 ### IonicVue
 
-`IonicVue` abstracts DOM interaction of Ionic UI components inside a Vue application and can be used via `this.$ionic`.
+`IonicVue` abstracts DOM interaction of Ionic UI components inside a Vue application.
+:warning: Use of `this.$ionic` or `Vue.$ionic` is deprecated and will be removed in the near future. Please use the example below instead:
 
 ```js
+import { alertController } from '@ionic/vue';
+
 Vue.component('Foo', {
   methods: {
     notify() {
-      this.$ionic.alertController
+      alertController
         .create({
           header: 'Notification',
           subHeader: null,

package.json

@@ -49,7 +49,7 @@
   "scripts": {
     "dev": "rollup -c ./build/rollup.config.js",
     "watch": "rollup -w -c ./build/rollup.config.js",
-    "prod": "NODE_ENV=production rollup -c ./build/rollup.config.js --configProd",
+    "prod": "npm run clean && NODE_ENV=production rollup -c ./build/rollup.config.js --configProd",
     "lint": "tslint --project .",
     "lint.fix": "tslint --project . --fix",
     "test": "jest --coverage --verbose",

scripts/clean.js

@@ -0,0 +1,9 @@
+const fs = require('fs-extra')
+const path = require('path')
+
+const cleanDirs = ['dist']
+
+cleanDirs.forEach(dir => {
+  const cleanDir = path.join(__dirname, '../', dir)
+  fs.removeSync(cleanDir)
+})

src/components/navigation/ion-tabs.ts

@@ -1,7 +1,9 @@
 import Vue, { CreateElement, RenderContext, VNode } from 'vue';
 import { Route } from 'vue-router';
 
+
 interface EventListeners {
+  // tslint:disable-next-line:ban-types
   [key: string]: Function | Function[];
 }
 
@@ -158,6 +160,7 @@ function parseTabBar(vnode: VNode, tab: string, listeners: EventListeners): VNod
           if (Array.isArray(child.data.on.click)) {
             child.data.on.click.push(clickHandler);
           } else {
+            // tslint:disable-next-line:ban-types
             child.data.on.click = [child.data.on.click as Function, clickHandler];
           }
         }