vs warnings

Author: MarcG-TUE

include/maxplus/algebra/mpmatrix.h

@@ -320,7 +320,7 @@ inline unsigned int VectorList::getSize() const { return static_cast<unsigned in
 
 inline void VectorList::grow() {
     auto last = static_cast<unsigned int>(this->size());
-    this->resize(last + 1);
+    this->resize(static_cast<size_t>(last + 1));
     this->insert(this->begin() + last, std::make_unique<Vector>(oneVectorSize, MP_MINUSINFINITY));
 }
 

src/base/analysis/mcm/mcmdg.cc

@@ -62,7 +62,7 @@ CDouble mcmDG(MCMgraph *mcmGraph) {
     std::vector<std::vector<int>> d(n + 1, std::vector<int>(n));
 
     // Initialize
-    for (int i = 0; i < n; i++) {
+    for (unsigned int i = 0; i < n; i++) {
         level[i] = -1;
     }
     d[0][0] = 0;
@@ -74,7 +74,7 @@ CDouble mcmDG(MCMgraph *mcmGraph) {
     Q_u.push_back(&(mcmGraph->getNodes().front()));
 
     // Compute the distances
-    int k = Q_k.front();
+    unsigned int k = Q_k.front();
     Q_k.pop_front();
     MCMnode* u = Q_u.front();
     Q_u.pop_front();
@@ -83,7 +83,7 @@ CDouble mcmDG(MCMgraph *mcmGraph) {
             MCMedge* e = *iter;
             MCMnode* v = e->dst;
 
-            if (level[v->id] < k + 1) {
+            if (level[v->id] < static_cast<int>(k + 1)) {
                 Q_k.push_back(k + 1);
                 Q_u.push_back(v);
                 pi[k + 1][v->id] = level[v->id];

src/base/analysis/mcm/mcmgraph.cc

@@ -105,11 +105,11 @@ MCMnode::MCMnode(CId nId, bool nVisible) : id(nId), visible(nVisible) {}
  */
 static void splitMCMedgeToSequence(MCMgraph &g, MCMedge &e) {
     // Create dummy node n;
-    MCMnode *n = g.addNode(g.getNodes().size());
+    MCMnode *n = g.addNode(static_cast<CId>(g.getNodes().size()));
 
     // Create a new edge between the src node of e and a new
     // dummy node.
-    MCMedge *eN = g.addEdge(g.getEdges().size(), *e.src, *n, 0, e.d - 1);
+    MCMedge *eN = g.addEdge(static_cast<CId>(g.getEdges().size()), *e.src, *n, 0, e.d - 1);
 
     // Remove e from the set of edges its source node is connected to
     // and add eN to this list
@@ -226,7 +226,7 @@ static void addLongestDelayEdgeForNode(MCMgraph &g, MCMnode &n, MCMedge &e) {
         if (d[m->id] > 0 && e.dst->id != m->id) {
             // Create an edge between n and m
             MCMedge *eN = g.addEdge(
-                    g.getEdges().size(), n, *m, d[m->id], e.d, false); // e.d should always be 1
+                    static_cast<CId>(g.getEdges().size()), n, *m, d[m->id], e.d, false); // e.d should always be 1
             n.out.push_back(eN);
             m->in.push_back(eN);
         }
@@ -435,7 +435,7 @@ static void addNodeToComponent(const MCMnode &n, MCMgraph &comp) {
     // in the previous loop already
     for (const auto &e : n.in) {
         // Is source node in the component?
-        for (auto iterN : comp.getNodes()) {
+        for (auto& iterN : comp.getNodes()) {
             // if the source node is in the component and it is not a self-edge
             if ((e->src->id == iterN.id) && (e->src->id != e->dst->id)) {
                 // Add a copy of the edge to the component

src/base/analysis/mcm/mcmhoward.cc

@@ -187,7 +187,7 @@ class AlgHoward {
             v_aux[i] = EPSILON;
         }
 
-        for (unsigned int i = 0; i < narcs; i++) {
+        for (int i = 0; i < narcs; i++) {
             if (v_aux[ij[i * 2]] <= a[i]) {
                 (**pi)[ij[i * 2]] = ij[i * 2 + 1];
                 c[ij[i * 2]] = a[i];

src/base/analysis/mcm/mcmkarp.cc

@@ -73,18 +73,18 @@ CDouble maximumCycleMeanKarp(MCMgraph &mcmGraph) {
 
     // Initialize
     // d[k][u], 1<=k<n+1, 0<=u<n with value -inf
-    for (int k = 1; k < n + 1; k++) {
-        for (int u = 0; u < n; u++) {
+    for (unsigned int k = 1; k < n + 1; k++) {
+        for (unsigned int u = 0; u < n; u++) {
             d[k][u] = -INT_MAX;
         }
     }
     // d[0][u], 0<=u<n with value 0
-    for (int u = 0; u < n; u++) {
+    for (unsigned int u = 0; u < n; u++) {
         d[0][u] = 0;
     }
 
     // Compute the distances
-    for (int k = 1; k < n + 1; k++) {
+    for (unsigned int k = 1; k < n + 1; k++) {
         for (const auto& v : mcmGraph.getNodes()) {
              for (auto e = v.in.begin(); e != v.in.end(); e++) {
                 MCMnode* u = (*e)->src;
@@ -97,7 +97,7 @@ CDouble maximumCycleMeanKarp(MCMgraph &mcmGraph) {
     CDouble l = -INT_MAX;
     for (const auto & u : mcmGraph.getNodes()) {
         CDouble ld = INT_MAX;
-        for (int k = 0; k < n; k++) {
+        for (unsigned int k = 0; k < n; k++) {
             ld = MIN(ld, (CDouble)(d[n][u.id] - d[k][u.id]) / (CDouble)(n - k));
         }
         l = MAX(l, ld);
@@ -125,18 +125,18 @@ CDouble maximumCycleMeanKarpDouble(MCMgraph &mcmGraph, const MCMnode **criticalN
 
     // Initialize
     // d[k][u], 1<=k<n+1, 0<=u<n with value -inf
-    for (int k = 1; k < n + 1; k++) {
-        for (int u = 0; u < n; u++) {
+    for (unsigned int k = 1; k < n + 1; k++) {
+        for (unsigned int u = 0; u < n; u++) {
             d[k][u] = -DBL_MAX;
         }
     }
     // d[0][u], 0<=u<n with value 0
-    for (int u = 0; u < n; u++) {
+    for (unsigned int u = 0; u < n; u++) {
         d[0][u] = 0.0;
     }
 
     // Compute the distances
-    for (int k = 1; k < n + 1; k++) {
+    for (unsigned int k = 1; k < n + 1; k++) {
         for (const auto& v : mcmGraph.getNodes()) {
              for (auto e = v.in.begin(); e != v.in.end(); e++) {
                 MCMnode* u = (*e)->src;
@@ -149,7 +149,7 @@ CDouble maximumCycleMeanKarpDouble(MCMgraph &mcmGraph, const MCMnode **criticalN
     CDouble l = -DBL_MAX;
     for (const auto& u : mcmGraph.getNodes()) {
         CDouble ld = DBL_MAX;
-        for (int k = 0; k < n; k++) {
+        for (unsigned int k = 0; k < n; k++) {
             CDouble nld = (d[n][u.id] - d[k][u.id]) / static_cast<CDouble>(n - k);
             if (nld < ld) {
                 ld = nld;

src/base/string/cstring.cc

@@ -81,7 +81,7 @@ CString::CString(const CString &s) = default;
  */
 CString::CString(const int n) {
     char str[32];
-    sprintf(&str[0], "%i", n);
+    sprintf_s(&str[0], 32, "%i", n);
     append(std::string(str));
 }
 
@@ -91,7 +91,7 @@ CString::CString(const int n) {
  */
 CString::CString(const unsigned int n) {
     char str[32];
-    sprintf(&str[0], "%u", n);
+    sprintf_s(&str[0], 32, "%u", n);
     append(std::string(str));
 }
 
@@ -101,7 +101,7 @@ CString::CString(const unsigned int n) {
  */
 CString::CString(const long int n) {
     char str[32];
-    sprintf(&str[0], "%ld", n);
+    sprintf_s(&str[0], 32, "%ld", n);
     append(std::string(str));
 }
 
@@ -111,7 +111,7 @@ CString::CString(const long int n) {
  */
 CString::CString(const unsigned long int n) {
     char str[32];
-    sprintf(&str[0], "%ld", n);
+    sprintf_s(&str[0], 32, "%ld", n);
     append(std::string(str));
 }
 
@@ -121,7 +121,7 @@ CString::CString(const unsigned long int n) {
  */
 CString::CString(const long long int n) {
     char str[32];
-    sprintf(&str[0], "%lld", n);
+    sprintf_s(&str[0], 32, "%lld", n);
     append(std::string(str));
 }
 
@@ -131,7 +131,7 @@ CString::CString(const long long int n) {
  */
 CString::CString(const unsigned long long int n) {
     char str[32];
-    sprintf(&str[0], "%lld", n);
+    sprintf_s(&str[0], 32, "%lld", n);
     append(std::string(str));
 }
 
@@ -141,7 +141,7 @@ CString::CString(const unsigned long long int n) {
  */
 CString::CString(const CDouble n) {
     char str[32];
-    sprintf(&str[0], "%g", n);
+    sprintf_s(&str[0], 32, "%g", n);
     append(std::string(str));
 }
 
@@ -447,8 +447,8 @@ bool isTok(const char c, const char *tok) { return (strchr(tok, c) != nullptr);
  * Split a string into tokens using the given token delimiter.
  */
 void stringTok(CStrings &l, CString &str, const char *tok) {
-    const CString::size_type S = str.size();
-    CString::size_type i = 0;
+    const int S = static_cast<int>(str.size());
+    int i = 0;
 
     // Clear list of strings
     l.clear();
@@ -464,7 +464,7 @@ void stringTok(CStrings &l, CString &str, const char *tok) {
         }
 
         // find end of word
-        CString::size_type j = i + 1;
+        int j = i + 1;
         while ((j < S) && (!isTok(str[j], tok))) {
             ++j;
         }

src/testbench/game/policyiterationtest.cc

@@ -184,7 +184,7 @@ void PolicyIterationTest::testInvalidInputGraphTest() {
                 new PolicyIteration<MPAStateLabel, MPAREdgeLabel>();
         PolicyIteration<MPAStateLabel, MPAREdgeLabel>::PolicyIterationResult result =
                 pi->solve(mpa);
-    } catch (const std::runtime_error &error) {
+    } catch (const std::runtime_error&) {
         // test passes
         // SUCCEED();
     }