fix find edge

Author: MarcG-TUE

include/maxplus/base/fsm/fsm.h

@@ -580,25 +580,23 @@ class FiniteStateMachine : public Abstract::FiniteStateMachine {
     // check if there exists a transition e = (q1,alpha,q2)
     const Edge<StateLabelType, EdgeLabelType> *
     findEdge(StateLabelType src, EdgeLabelType lbl, StateLabelType dst) {
-        Edge<StateLabelType, EdgeLabelType> *found = nullptr;
 
         // get all labels
         SetOfStates<StateLabelType, EdgeLabelType> &allStates = this->getStates();
 
         for (auto iter : allStates) {
-            auto s = *iter;
-            if (s->stateLabel == src) {
+            auto s = dynamic_cast<State<StateLabelType, EdgeLabelType>&>(*(iter.second));
+            if (s.stateLabel == src) {
                 State<StateLabelType, EdgeLabelType> &srcState = this->getStateLabeled(src);
 
                 const auto &outgoingEdges =
                         static_cast<const Abstract::SetOfEdgeRefs &>(srcState.getOutgoingEdges());
 
                 for (const auto &it : outgoingEdges) {
                     auto e = dynamic_cast<const Edge<StateLabelType, EdgeLabelType> *>(it);
-                    auto dstState = e->getDestination();
-                    if (e->label == lbl && dstState->getLabel() == dst) {
-                        found = e;
-                        return found;
+                    auto dstState = dynamic_cast<const State<StateLabelType, EdgeLabelType>&>(e->getDestination());
+                    if (e->getLabel() == lbl && dstState.getLabel() == dst) {
+                        return e;
                     }
                 }
             }

src/testbench/graph/mpautomatontest.cc

@@ -52,6 +52,9 @@ void MPAutomatonTest::testCreateFSM() {
     auto s = mpa.checkStateLabeled(makeMPAStateLabel(0, 1));
     ASSERT_THROW(s != nullptr);
 
+    auto e = mpa.findEdge(makeMPAStateLabel(0, 0), makeRewardEdgeLabel(MPTime(3.0), CString("A"), 1.0), makeMPAStateLabel(0, 1));
+    ASSERT_THROW(e != nullptr);
+
     ASSERT_EQUAL_NOPRINT(s1, &(mpa.getInitialState()));
 }