some fixes

Author: Marc Geilen

include/maxplus/algebra/mptype.h

@@ -115,6 +115,7 @@ inline CDouble MP_MIN(CDouble a, CDouble b) { return CDouble(MP_MIN(MPTime(a), M
 const MPTime MP_MINUSINFINITY = MPTime(-1.0e+30);
 
 inline bool MP_ISMINUSINFINITY(CDouble a) { return a < MPTIME_MIN_INF_VAL; }
+inline bool MP_ISMINUSINFINITY(MPTime a) { return a < MP_MINUSINFINITY; }
 
 inline MPTime MP_PLUS(CDouble a, CDouble b) {
     return (MP_ISMINUSINFINITY(a) || MP_ISMINUSINFINITY(b)) ? MP_MINUSINFINITY

include/maxplus/base/fsm/fsm.h

@@ -197,7 +197,7 @@ class FiniteStateMachine {
     FiniteStateMachine(FiniteStateMachine &&) = default;
     FiniteStateMachine &operator=(FiniteStateMachine &&) = delete;
 
-    [[nodiscard]] virtual const State &getInitialState() const = 0;
+    [[nodiscard]] virtual State &getInitialState() = 0;
 };
 
 //
@@ -414,7 +414,7 @@ class FiniteStateMachine : public Abstract::FiniteStateMachine {
 private:
     SetOfStates<StateLabelType, EdgeLabelType> states;
     Abstract::SetOfEdges edges;
-    const State<StateLabelType, EdgeLabelType> *initialState;
+    State<StateLabelType, EdgeLabelType> *initialState;
 
 public:
     FiniteStateMachine() : Abstract::FiniteStateMachine(), initialState(nullptr){};
@@ -473,12 +473,12 @@ class FiniteStateMachine : public Abstract::FiniteStateMachine {
         this->initialState = this->states.withLabel(label);
     };
 
-    void setInitialState(const State<StateLabelType, EdgeLabelType>& s) {
+    void setInitialState(State<StateLabelType, EdgeLabelType>& s) {
         // we are asumming s is one of our states
         this->initialState = &s;
     };
 
-    [[nodiscard]] const State<StateLabelType, EdgeLabelType> &getInitialState() const override {
+    [[nodiscard]] State<StateLabelType, EdgeLabelType> &getInitialState() override {
         return *this->initialState;
     };
 
@@ -854,6 +854,7 @@ using ELSSetOfEdgeRefs = ::FSM::Abstract::SetOfEdgeRefs;
 
 class EdgeLabeledScenarioFSM : public ::FSM::Labeled::FiniteStateMachine<CId, CString> {
 public:
+    EdgeLabeledScenarioFSM() = default;
     ~EdgeLabeledScenarioFSM() override = default;
 
     EdgeLabeledScenarioFSM(const EdgeLabeledScenarioFSM &) = delete;
@@ -887,8 +888,8 @@ class State : public Labeled::State<CString, char> {
 
 class FiniteStateMachine : public Labeled::FiniteStateMachine<CString, char> {
 public:
-    const State &getInitialState() {
-        return dynamic_cast<const State &>(
+    State &getInitialState() {
+        return dynamic_cast<State &>(
                 Labeled::FiniteStateMachine<CString, char>::getInitialState());
     };
 
@@ -930,7 +931,7 @@ class FiniteStateMachine : public Abstract::FiniteStateMachine {
                        const Abstract::FiniteStateMachine &fsm2) :
         fsm_a(fsm1), fsm_b(fsm2) {}
 
-    std::shared_ptr<State> getInitialState();
+    State& getInitialState();
 
     [[nodiscard]] virtual bool matchEdges(const Abstract::Edge &e1,
                                           const Abstract::Edge &e2) const = 0;

include/maxplus/graph/mpautomaton.h

@@ -126,7 +126,7 @@ class MaxPlusAutomaton : public ::FSM::Labeled::FiniteStateMachine<MPAStateLabel
  */
 using MPAREdgeLabel = struct MPAREdgeLabel {
     MPDelay delay;
-    const CString& scenario;
+    const CString scenario;
     CDouble reward{0.0};
 };
 
@@ -143,7 +143,7 @@ using MPARState = ::FSM::Labeled::State<MPAStateLabel, MPAREdgeLabel>;
 using MPAREdge = ::FSM::Labeled::Edge<MPAStateLabel, MPAREdgeLabel>;
 using MPARSetOfStates = ::FSM::Labeled::SetOfStates<MPAStateLabel, MPAREdgeLabel>;
 using MPARSetOfEdges = ::FSM::Abstract::SetOfEdges;
-using MPARCycle = ::FSM::Abstract::SetOfEdgeRefs;
+using MPARCycle = std::list<const ::FSM::Abstract::Edge*>;
 
 /**
  * A max-plus automaton with rewards. In addition to the usual max-plus automaton,