[desktop_webview_window] More control over webview position and size under windows (#206)

* OpenDevTools

* Control Webview Size and Position and Maximization

* clear non plugin stuff

* clear non plugin stuff 2

Author: Iri-Hor

packages/desktop_webview_window/lib/src/create_configuration.dart

@@ -4,6 +4,10 @@ class CreateConfiguration {
   final int windowWidth;
   final int windowHeight;
 
+  /// Position of the top left point of the webview window
+  final int windowPosX;
+  final int windowPosY;
+
   /// the title of window
   final String title;
 
@@ -13,13 +17,20 @@ class CreateConfiguration {
 
   final String userDataFolderWindows;
 
+  final bool useWindowPositionAndSize;
+  final bool openMaximized;
+
   const CreateConfiguration({
     this.windowWidth = 1280,
     this.windowHeight = 720,
+    this.windowPosX = 0,
+    this.windowPosY = 0,
     this.title = "",
     this.titleBarHeight = 40,
     this.titleBarTopPadding = 0,
     this.userDataFolderWindows = 'webview_window_WebView2',
+    this.useWindowPositionAndSize = false,
+    this.openMaximized = false,
   });
 
   factory CreateConfiguration.platform() {
@@ -31,9 +42,13 @@ class CreateConfiguration {
   Map toMap() => {
         "windowWidth": windowWidth,
         "windowHeight": windowHeight,
+        "windowPosX": windowPosX,
+        "windowPosY": windowPosY,
         "title": title,
         "titleBarHeight": titleBarHeight,
         "titleBarTopPadding": titleBarTopPadding,
         "userDataFolderWindows": userDataFolderWindows,
+        "useWindowPositionAndSize": useWindowPositionAndSize,
+        "openMaximized": openMaximized,
       };
 }

packages/desktop_webview_window/windows/web_view.cc

@@ -5,7 +5,6 @@
 #include <windows.h>
 #include <tchar.h>
 #include <cassert>
-#include <iostream>
 #include <utility>
 #include <thread>
 

packages/desktop_webview_window/windows/web_view_window_plugin.cc

@@ -56,6 +56,10 @@ void WebviewWindowPlugin::HandleMethodCall(
     auto title = std::get<std::string>(arguments->at(flutter::EncodableValue("title")));
     auto titleBarHeight = arguments->at(flutter::EncodableValue("titleBarHeight")).LongValue();
     auto userDataFolder = std::get<std::string>(arguments->at(flutter::EncodableValue("userDataFolderWindows")));
+    auto useWindowPositionAndSize = std::get<bool>(arguments->at(flutter::EncodableValue("useWindowPositionAndSize")));
+    auto openMaximized = std::get<bool>(arguments->at(flutter::EncodableValue("openMaximized")));
+    auto windowPosX = arguments->at(flutter::EncodableValue("windowPosX")).LongValue();
+    auto windowPosY = arguments->at(flutter::EncodableValue("windowPosY")).LongValue();
 
     auto window_id = next_window_id_;
     auto window = std::make_unique<WebviewWindow>(
@@ -66,6 +70,7 @@ void WebviewWindowPlugin::HandleMethodCall(
     std::shared_ptr<flutter::MethodResult<flutter::EncodableValue>> result2(std::move(result));
     window->CreateAndShow(
         utf8_to_wide(title), int(height), int(width), utf8_to_wide(userDataFolder),
+        int(windowPosX), int(windowPosY), useWindowPositionAndSize, openMaximized,
         [this, window_id, result(result2)](bool succeed) mutable {
           if (!succeed) {
             result->Error("0", "failed to show window");

packages/desktop_webview_window/windows/webview_window.cc

@@ -52,7 +52,8 @@ WebviewWindow::~WebviewWindow() {
 
 void WebviewWindow::CreateAndShow(const std::wstring &title, int height, int width,
                                   const std::wstring &userDataFolder,
-                                  CreateCallback callback) {
+                                  int windowPosX, int windowPosY, bool useWindowPositionAndSize,
+                                  bool openMaximized, CreateCallback callback) {
 
   RegisterWindowClass(kWebViewWindowClassName, WebviewWindow::WndProc);
 
@@ -64,12 +65,25 @@ void WebviewWindow::CreateAndShow(const std::wstring &title, int height, int wid
   UINT dpi = FlutterDesktopGetDpiForMonitor(monitor);
   double scale_factor = dpi / 96.0;
 
-  hwnd_ = wil::unique_hwnd(::CreateWindow(
+  DWORD dwStyle = WS_OVERLAPPEDWINDOW | WS_VISIBLE;
+  if (openMaximized)
+    dwStyle |= WS_MAXIMIZE;
+
+  if (useWindowPositionAndSize) {
+    hwnd_ = wil::unique_hwnd(::CreateWindow(
+      kWebViewWindowClassName, title.c_str(),
+      dwStyle,
+      windowPosX, windowPosY,
+      width, height,
+      nullptr, nullptr, GetModuleHandle(nullptr), this));
+  } else {
+    hwnd_ = wil::unique_hwnd(::CreateWindow(
       kWebViewWindowClassName, title.c_str(),
-      WS_OVERLAPPEDWINDOW | WS_VISIBLE,
+      dwStyle,
       CW_USEDEFAULT, CW_USEDEFAULT,
       Scale(width, scale_factor), Scale(height, scale_factor),
       nullptr, nullptr, GetModuleHandle(nullptr), this));
+  }
   if (!hwnd_) {
     callback(false);
     return;
@@ -78,8 +92,10 @@ void WebviewWindow::CreateAndShow(const std::wstring &title, int height, int wid
   // Centered window on screen.
   RECT rc;
   GetClientRect(hwnd_.get(), &rc);
-  ClipOrCenterRectToMonitor(&rc, MONITOR_CENTER);
-  SetWindowPos(hwnd_.get(), nullptr, rc.left, rc.top, 0, 0, SWP_NOSIZE | SWP_NOZORDER | SWP_NOACTIVATE);
+  if (!useWindowPositionAndSize && !openMaximized) {
+    ClipOrCenterRectToMonitor(&rc, MONITOR_CENTER);
+    SetWindowPos(hwnd_.get(), nullptr, rc.left, rc.top, 0, 0, SWP_NOSIZE | SWP_NOZORDER | SWP_NOACTIVATE);
+  }
 
   auto title_bar_height = Scale(title_bar_height_, scale_factor);
 

packages/desktop_webview_window/windows/webview_window.h

@@ -40,7 +40,8 @@ class WebviewWindow {
 
   void CreateAndShow(const std::wstring &title, int height, int width,
                      const std::wstring &userDataFolder,
-                     CreateCallback callback);
+                     int windowPosX, int windowPosY, bool useWindowPositionAndSize,
+                     bool openMaximized, CreateCallback callback);
 
   // OS callback called by message pump. Handles the WM_NCCREATE message which
   // is passed when the non-client area is being created and enables automatic