Skip to content

Commit ecce706

Browse files
authored
Correct API Definition of post webmessages (#202)
1 parent f797e51 commit ecce706

File tree

3 files changed

+5
-5
lines changed

3 files changed

+5
-5
lines changed

packages/desktop_webview_window/lib/src/webview.dart

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -82,8 +82,8 @@ abstract class Webview {
8282
Future<String?> evaluateJavaScript(String javaScript);
8383

8484
/// post a web message as String to the top level document in this WebView
85-
Future<String?> postWebMessageAsString(String webMessage);
85+
Future<void> postWebMessageAsString(String webMessage);
8686

8787
/// post a web message as JSON to the top level document in this WebView
88-
Future<String?> postWebMessageAsJson(String webMessage);
88+
Future<void> postWebMessageAsJson(String webMessage);
8989
}

packages/desktop_webview_window/lib/src/webview_impl.dart

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -236,15 +236,15 @@ class WebviewImpl extends Webview {
236236
}
237237

238238
@override
239-
Future<String?> postWebMessageAsString(String webMessage) async {
239+
Future<void> postWebMessageAsString(String webMessage) async {
240240
return channel.invokeMethod("postWebMessageAsString", {
241241
"viewId": viewId,
242242
"webMessage": webMessage,
243243
});
244244
}
245245

246246
@override
247-
Future<String?> postWebMessageAsJson(String webMessage) async {
247+
Future<void> postWebMessageAsJson(String webMessage) async {
248248
return channel.invokeMethod("postWebMessageAsJson", {
249249
"viewId": viewId,
250250
"webMessage": webMessage,

packages/desktop_webview_window/windows/web_view.cc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -303,7 +303,7 @@ void WebView::PostWebMessageAsString(const std::wstring &webmessage,
303303
webmessage.c_str()) == NOERROR) {
304304
completer->Success();
305305
} else {
306-
completer->Error("0", "Error posting webmessage as String");
306+
completer->Error("0", "Error posting webmessage as String");
307307
}
308308
} else {
309309
completer->Error("0", "webview not created");

0 commit comments

Comments
 (0)